Skip to content

Commit 0528343

Browse files
author
Bob Farrell
committed
I cited the scapy module as being the cause of a problem, it wasn't.
It was actually a problem in the logging module. committer: Bob Farrell <bob@keys.(none)>
1 parent 4c12afd commit 0528343

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎bpython.py‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,7 @@ def write( self, s ):
766766
self.s_hist.append( s.rstrip('\n') )
767767

768768
def flush( self ):
769-
"""Olivier Grisel brought it to my attention that the scapy
769+
"""Olivier Grisel brought it to my attention that the logging
770770
module tries to call this method, since it makes assumptions
771771
about stdout that may not necessarily be true. The docs for
772772
sys.stdout say:
@@ -775,8 +775,9 @@ def flush( self ):
775775
object is acceptable as long as it has a write() method
776776
that takes a string argument."
777777
778-
So I consider this to be a bug in scapy, and this is a hack
779-
to fix it, unfortunately. I'm sure they're not the only ones."""
778+
So I consider this to be a bug in logging, and this is a hack
779+
to fix it, unfortunately. I'm sure it's not the only module
780+
to do it."""
780781
pass
781782

782783
def echo( self, s, redraw=True ):

0 commit comments

Comments
 (0)