Skip to content

Commit a01faf7

Browse files
Tatu Aaltopekkaklarck
authored andcommitted
Fine tuning
1 parent a86816a commit a01faf7

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

src/SeleniumLibrary/locators/elementfinder.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,8 @@ def _is_webelement(self, element):
131131
return isinstance(element, WebElement)
132132

133133
def _disallow_webelement_parent(self, element):
134-
if isinstance(element, WebElement):
134+
if self._is_webelement(element):
135135
raise ValueError('This method does not allow webelement as parent')
136-
return True
137136

138137
def _find_by_identifier(self, criteria, tag, constraints, parent):
139138
elements = self._normalize_result(parent.find_elements_by_id(criteria))
@@ -150,9 +149,8 @@ def _find_by_name(self, criteria, tag, constraints, parent):
150149
tag, constraints)
151150

152151
def _find_by_xpath(self, criteria, tag, constraints, parent):
153-
return self._filter_elements(
154-
parent.find_elements_by_xpath(criteria),
155-
tag, constraints)
152+
return self._filter_elements(parent.find_elements_by_xpath(criteria),
153+
tag, constraints)
156154

157155
def _find_by_dom(self, criteria, tag, constraints, parent):
158156
self._disallow_webelement_parent(parent)

0 commit comments

Comments
 (0)