Add include_children parameter when creating MemTimer object for external processes #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal processes. Fix #69
Collaborator
|
Thanks @guillermo-carrasco! The fix for the issue looks good but I'm not sure about the second fix for |
Contributor
Author
|
Ops my bad, you're right. I didn't realise that. I just discovered what was happening: One of the tests I was doing was calling another script that used Should be fine now. |
fabianp
added a commit
that referenced
this pull request
Jan 28, 2014
Add include_children parameter when creating MemTimer object for external processes
Collaborator
|
Perfect, merged. Thanks! |
Contributor
Author
|
Great, thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
With a bit of debugging I found the problem, and a solution for issue #69. It is just a forgotten parameter when creating the object MemTimer when benchmarking external processes.
Also, I noticed that even if psutil module is found, the
_get_memoryfunction will calculate the memory twice ifos.name == 'posix', which was the case in my Mac OSX. I just put anelifthere.I have tested this fix executing memory_usage on functions that create threads (i.e with multiprocessing.Pool), as well as with functions that call external programs that in turn create several threads (i.e subprocess.check_call).
Hope that helps!