Fixed existing user creation when accessing Pytools LP

renzon · renzon · commit ef9789de4632 · 2019-07-22T20:43:30.000-03:00
close #1332
diff --git a/Pipfile.lock b/Pipfile.lock
diff --git a/pythonpro/payments/tests/test_pagarme_boleto.py b/pythonpro/payments/tests/test_pagarme_boleto.py
@@ -1,6 +1,7 @@
 import pytest
 import responses
 from django.urls import reverse
+from model_mommy import mommy
 from rolepermissions.checkers import has_role
 
 from pythonpro.django_assertions import dj_assert_contains
@@ -219,3 +220,14 @@ def test_client_update_on_mail_chimp(resp_token_with_no_user, django_user_model,
 
 def test_client_lead_not_created_on_mailchimp(resp_token_with_no_user, django_user_model, create_or_update_lead):
     create_or_update_lead.assert_called_once_with(CUSTOMER_FIRST_NAME, CUSTOMER_EMAIL)
+
+
+@pytest.fixture
+def resp_existing_user_not_logged(db, client, create_or_update_client, create_or_update_lead, resps_success,
+                                  django_user_model):
+    mommy.make(django_user_model, email=CUSTOMER_EMAIL)
+    return client.post(reverse('payments:pytools_capture'), transaction_data, secure=True)
+
+
+def test_existing_user_not_created(resp_existing_user_not_logged, django_user_model):
+    assert 1 == django_user_model.objects.all().count()
diff --git a/pythonpro/payments/views.py b/pythonpro/payments/views.py
@@ -36,17 +36,18 @@ def pytools_capture(request):
     user = request.user
     if not user.is_authenticated:
         customer = pagarme_resp['customer']
-        customer_first_name = customer['name'].split()[0]
         customer_email = customer['email']
-        form = UserSignupForm({'first_name': customer_first_name, 'email': customer_email})
-        source = request.GET.get('utm_source', default='unknown')
-        user = form.save(source=source)
-        if not pagarme_resp['payment_method'] == 'credit_card':
-            assign_role(user, 'lead')
-            try:
-                mailchimp_facade.create_or_update_lead(customer_first_name, customer_email)
-            except MailChimpError:
-                pass
+        if not get_user_model().objects.filter(email=customer_email).exists():
+            customer_first_name = customer['name'].split()[0]
+            form = UserSignupForm({'first_name': customer_first_name, 'email': customer_email})
+            source = request.GET.get('utm_source', default='unknown')
+            user = form.save(source=source)
+            if not pagarme_resp['payment_method'] == 'credit_card':
+                assign_role(user, 'lead')
+                try:
+                    mailchimp_facade.create_or_update_lead(customer_first_name, customer_email)
+                except MailChimpError:
+                    pass
 
     if pagarme_resp['payment_method'] == 'credit_card':
         _promote_client(user, request)
