Added Google Tag Manager

renzon · renzon · commit ec5749e7cfb6 · 2019-06-26T16:23:36.000-03:00
close #1273 Removed Pixels from Facebook and Hotjar since they'll be managed by GTM
diff --git a/contrib/env-sample b/contrib/env-sample
@@ -32,9 +32,6 @@ DISCOURSE_SSO_SECRET=
 MAILCHIMP_API_KEY=00000000000000000000000000000000-us17
 MAILCHIMP_LIST_ID=list_id
 
-# Facebook config
-FACEBOOK_PIXEL_ID=123456789012345
-
 # Google Tag Manager Config
 GOOGLE_TAG_MANAGER_ID=GTM-ABC1234
                   
diff --git a/pythonpro/core/context_processors.py b/pythonpro/core/context_processors.py
@@ -6,7 +6,6 @@ def global_settings(request):
     dct = {
         'DEFAULT_FROM_EMAIL': settings.DEFAULT_FROM_EMAIL,
         'DISCOURSE_BASE_URL': settings.DISCOURSE_BASE_URL,
-        'FACEBOOK_PIXEL_ID': settings.FACEBOOK_PIXEL_ID,
         'GOOGLE_TAG_MANAGER_ID': settings.GOOGLE_TAG_MANAGER_ID,
     }
     return dct
diff --git a/pythonpro/core/templates/core/base.html b/pythonpro/core/templates/core/base.html
@@ -17,57 +17,21 @@
         Sentry.init({ dsn: '{{ SENTRY_DSN }}' });
     </script>
     <script async src="https://www.googletagmanager.com/gtag/js?id=UA-44718512-1"></script>
-    <script>
-      window.dataLayer = window.dataLayer || [];
-      function gtag(){dataLayer.push(arguments);}
-      gtag('js', new Date());
-
-      gtag('config', 'UA-44718512-1');
-    </script>
-    
-    {% if FACEBOOK_PIXEL_ID %}
-    <!-- Facebook Pixel Code -->
-    <script>
-    !function (f, b, e, v, n, t, s) {
-        if (f.fbq) return; n = f.fbq = function () {
-        n.callMethod ?
-        n.callMethod.apply(n, arguments) : n.queue.push(arguments)
-        };
-        if (!f._fbq) f._fbq = n; n.push = n; n.loaded = !0; n.version = '2.0';
-        n.queue = []; t = b.createElement(e); t.async = !0;
-        t.src = v; s = b.getElementsByTagName(e)[0];
-        s.parentNode.insertBefore(t, s)
-    }(window, document, 'script',
-        'https://connect.facebook.net/en_US/fbevents.js');
-    fbq('init', '{{ FACEBOOK_PIXEL_ID }}');
-    fbq('track', 'PageView');
-    {% block facebook_pixel_track %}{% endblock %}
-    </script>
-    <noscript><img height="1" width="1" style="display:none"
-        src="https://www.facebook.com/tr?id=462601617885706&ev=PageView&noscript=1" /></noscript>
-    <!-- End Facebook Pixel Code -->
-    {% endif %}
-    
-    {% if GOOGLE_TAG_MANAGER_ID %}
-    <!-- Google Tag Manager -->
+    {#    Google Tag Manager#}
     <script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
     new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
     j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
     'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
     })(window,document,'script','dataLayer','{{GOOGLE_TAG_MANAGER_ID}}');</script>
-    <!-- End Google Tag Manager -->
-    {% endif %}
-    
+    {#     End Google Tag Manager#}
+
     {% block head %}{% endblock %}
 </head>
 <body>
-{% if GOOGLE_TAG_MANAGER_ID %}
-<!-- Google Tag Manager (noscript) -->
+{# Google Tag Manager (noscript)#}
 <noscript><iframe src="https://www.googletagmanager.com/ns.html?id={{GOOGLE_TAG_MANAGER_ID}}"
 height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
-<!-- End Google Tag Manager (noscript) -->
-{% endif %}
-
+{# End Google Tag Manager (noscript)#}
 {% block navbar %}
 <nav class="navbar navbar-dark bg-dark navbar-expand-md">
     <a class="navbar-brand" href="/">Python Pro</a>
@@ -179,32 +143,5 @@ <h3 class="mt-3">Entre em contato</h3>
         </div>
     </div>
 </footer>
-<script>
-    (function (i, s, o, g, r, a, m) {
-        i['GoogleAnalyticsObject'] = r;
-        i[r] = i[r] || function () {
-            (i[r].q = i[r].q || []).push(arguments)
-        }, i[r].l = 1 * new Date();
-        a = s.createElement(o),
-            m = s.getElementsByTagName(o)[0];
-        a.async = 1;
-        a.src = g;
-        m.parentNode.insertBefore(a, m)
-    })(window, document, 'script', '//www.google-analytics.com/analytics.js', 'ga');
-
-    ga('create', 'UA-44718512-1', 'python.pro.br');
-    ga('send', 'pageview');
-
-    <!-- Hotjar Tracking Code for www.python.pro.br -->
-    (function(h,o,t,j,a,r){
-        h.hj=h.hj||function(){(h.hj.q=h.hj.q||[]).push(arguments)};
-        h._hjSettings={hjid:1307735,hjsv:6};
-        a=o.getElementsByTagName('head')[0];
-        r=o.createElement('script');r.async=1;
-        r.src=t+h._hjSettings.hjid+j+h._hjSettings.hjsv;
-        a.appendChild(r);
-    })(window,document,'https://static.hotjar.com/c/hotjar-','.js?sv=');
-
-</script>
 </body>
 </html>
diff --git a/pythonpro/settings.py b/pythonpro/settings.py
@@ -228,12 +228,8 @@
     )
 
 # Mailchimp Configuration
-
 MAILCHIMP_API_KEY = config('MAILCHIMP_API_KEY')
 MAILCHIMP_LIST_ID = config('MAILCHIMP_LIST_ID')
 
-# Facebook Pixel Configuration
-FACEBOOK_PIXEL_ID = config('FACEBOOK_PIXEL_ID', default=None)
-
 # Google Tag Manager Configuration
-GOOGLE_TAG_MANAGER_ID = config('GOOGLE_TAG_MANAGER_ID', default=None)
+GOOGLE_TAG_MANAGER_ID = config('GOOGLE_TAG_MANAGER_ID')

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ def global_settings(request):`
`6`	`6`	`dct = {`
`7`	`7`	`'DEFAULT_FROM_EMAIL': settings.DEFAULT_FROM_EMAIL,`
`8`	`8`	`'DISCOURSE_BASE_URL': settings.DISCOURSE_BASE_URL,`
`9`		`- 'FACEBOOK_PIXEL_ID': settings.FACEBOOK_PIXEL_ID,`
`10`	`9`	`'GOOGLE_TAG_MANAGER_ID': settings.GOOGLE_TAG_MANAGER_ID,`
`11`	`10`	`}`
`12`	`11`	`return dct`