Fixed not recorded webinar usability

renzon · renzon · commit c3a0300ddb35 · 2020-03-13T10:03:41.000-03:00
part of #1681
diff --git a/pythonpro/cohorts/templates/cohorts/webinar_detail.html b/pythonpro/cohorts/templates/cohorts/webinar_detail.html
@@ -9,32 +9,37 @@
             <div class="col">
                 <h1 class="mt-4 mb-3">{{ webinar.title }}</h1>
                 <p>{{ webinar.description|linebreaks }}</p>
-                <div class="embed-container mb-3">
-                    <iframe src="https://player.vimeo.com/video/{{ webinar.vimeo_id }}" width="640" height="360"
-                            frameborder="0"
-                            webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>
-                </div>
-                <blockquote class="blockquote mt-2 mb-3" >
-                    <p class="mb-0">{{ webinar.speaker }}</p>
-                    <footer class="blockquote-footer">{{ webinar.speaker_title }}
-                    </footer>
-                </blockquote>
+                {% if webinar.vimeo_id %}
+                    <div class="embed-container mb-3">
+                        <iframe src="https://player.vimeo.com/video/{{ webinar.vimeo_id }}" width="640" height="360"
+                                frameborder="0"
+                                webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>
+                    </div>
 
-                <div id='discourse-comments'></div>
-                <script type="text/javascript">
-                    DiscourseEmbed = {
-                        discourseUrl: '{{ DISCOURSE_BASE_URL }}',
-                        topicId: {{ webinar.discourse_topic_id }}
-                    };
+                    <blockquote class="blockquote mt-2 mb-3">
+                        <p class="mb-0">{{ webinar.speaker }}</p>
+                        <footer class="blockquote-footer">{{ webinar.speaker_title }}
+                        </footer>
+                    </blockquote>
 
-                    (function () {
-                        var d = document.createElement('script');
-                        d.type = 'text/javascript';
-                        d.async = true;
-                        d.src = DiscourseEmbed.discourseUrl + 'javascripts/embed.js';
-                        (document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(d);
-                    })();
-                </script>
+                    <div id='discourse-comments'></div>
+                    <script type="text/javascript">
+                        DiscourseEmbed = {
+                            discourseUrl: '{{ DISCOURSE_BASE_URL }}',
+                            topicId: {{ webinar.discourse_topic_id }}
+                        };
+
+                        (function () {
+                            var d = document.createElement('script');
+                            d.type = 'text/javascript';
+                            d.async = true;
+                            d.src = DiscourseEmbed.discourseUrl + 'javascripts/embed.js';
+                            (document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(d);
+                        })();
+                    </script>
+                {% else %}
+                    <p class="mt-5 mb-5 h3">Ainda não temos máquina do tempo, esse webinário ainda não foi gravado 😉</p>
+                {% endif %}
 
             </div>
         </div>
diff --git a/pythonpro/cohorts/tests/test_webinar_detail.py b/pythonpro/cohorts/tests/test_webinar_detail.py
@@ -5,7 +5,7 @@
 
 from pythonpro.cohorts.models import Webinar
 from pythonpro.cohorts.tests.conftest import img_path
-from pythonpro.django_assertions import dj_assert_contains
+from pythonpro.django_assertions import dj_assert_contains, dj_assert_not_contains
 
 
 @pytest.fixture
@@ -34,6 +34,27 @@ def test_basic_contents(resp, webinar, property_name):
     dj_assert_contains(resp, getattr(webinar, property_name))
 
 
+@pytest.fixture
+def resp_video_not_recorded(client_with_member, webinar: Webinar):
+    webinar.vimeo_id = None
+    webinar.save()
+    return client_with_member.get(reverse('cohorts:webinar', kwargs={'slug': webinar.slug}), secure=True)
+
+
+def test_pending_webinar_msg(resp_video_not_recorded):
+    dj_assert_contains(
+        resp_video_not_recorded,
+        'Ainda não temos máquina do tempo, esse webinário ainda não foi gravado'
+    )
+
+
+def test_vime_player_not_present(resp_video_not_recorded):
+    dj_assert_not_contains(
+        resp_video_not_recorded,
+        'src="https://player.vimeo.com/video/"'
+    )
+
+
 @pytest.fixture
 def resp_client(client_with_client, webinar: Webinar, mocker, logged_user):
     return client_with_client.get(reverse('cohorts:webinar', kwargs={'slug': webinar.slug}), secure=True)
