Created configuration to turn ActiveCampaign off

renzon · renzon · commit 89ca0ea7385a · 2020-01-24T19:53:22.000-03:00
close #1908
diff --git a/contrib/env-sample b/contrib/env-sample
@@ -32,6 +32,8 @@ DISCOURSE_SSO_SECRET=
 # Active Campaign Config
 ACTIVE_CAMPAIGN_URL=
 ACTIVE_CAMPAIGN_KEY=
+# Make it False on dev to avoiding sending data to ActiveCampaign
+ACTIVE_CAMPAIGN_TURNED_ON=true
 
 # Google Tag Manager Config
 GOOGLE_TAG_MANAGER_ID=GTM-ABC1234
diff --git a/pythonpro/conftest.py b/pythonpro/conftest.py
@@ -54,4 +54,12 @@ def use_db_always(db):
     pass
 
 
+@pytest.fixture(autouse=True)
+def turn_active_campaign_on(settings):
+    """
+    This way test don't depend on local .env configuration
+    """
+    settings.ACTIVE_CAMPAIGN_TURNED_ON = True
+
+
 pytest_plugins = ['pythonpro.modules.tests.test_topics_view']
diff --git a/pythonpro/email_marketing/facade.py b/pythonpro/email_marketing/facade.py
@@ -41,6 +41,8 @@ def _normalise_id(id):
 
 
 def _create_or_update(name: str, email: str, role: str, *tags, id='0'):
+    if settings.ACTIVE_CAMPAIGN_TURNED_ON is False:
+        return
     prospect_list_id = _get_lists()['Prospects']
     id = _normalise_id(id)
     tags = list(tags)
@@ -77,6 +79,8 @@ def _find_active_campaign_contact_id(id):
 
 
 def grant_role(email, id, role: str):
+    if settings.ACTIVE_CAMPAIGN_TURNED_ON is False:
+        return
     role = role.lower()
     if role not in _ROLES:
         raise ValueError(f'Role {role} must be one of {_ROLES}')
@@ -100,6 +104,8 @@ def grant_role(email, id, role: str):
 
 
 def tag_as(email: str, id: int, *tags):
+    if settings.ACTIVE_CAMPAIGN_TURNED_ON is False:
+        return
     data = _build_tags_array(tags)
     try:
         data['id'] = _find_active_campaign_contact_id(id)
@@ -116,6 +122,8 @@ def _build_tags_array(tags) -> dict:
 
 
 def remove_tags(email: str, id: int, *tags):
+    if settings.ACTIVE_CAMPAIGN_TURNED_ON is False:
+        return
     data = _build_tags_array(tags)
     try:
         data['id'] = _find_active_campaign_contact_id(id)
diff --git a/pythonpro/settings.py b/pythonpro/settings.py
@@ -147,19 +147,19 @@
 AUTH_PASSWORD_VALIDATORS = [
     {
         'NAME':
-        'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',
+            'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',
     },
     {
         'NAME':
-        'django.contrib.auth.password_validation.MinimumLengthValidator',
+            'django.contrib.auth.password_validation.MinimumLengthValidator',
     },
     {
         'NAME':
-        'django.contrib.auth.password_validation.CommonPasswordValidator',
+            'django.contrib.auth.password_validation.CommonPasswordValidator',
     },
     {
         'NAME':
-        'django.contrib.auth.password_validation.NumericPasswordValidator',
+            'django.contrib.auth.password_validation.NumericPasswordValidator',
     },
 ]
 
@@ -240,6 +240,7 @@
 # Active Campaign Configuration
 ACTIVE_CAMPAIGN_URL = config('ACTIVE_CAMPAIGN_URL')
 ACTIVE_CAMPAIGN_KEY = config('ACTIVE_CAMPAIGN_KEY')
+ACTIVE_CAMPAIGN_TURNED_ON = config('ACTIVE_CAMPAIGN_TURNED_ON', cast=bool, default=True)
 
 # Google Tag Manager Configuration
 GOOGLE_TAG_MANAGER_ID = config('GOOGLE_TAG_MANAGER_ID')

Original file line number	Diff line number	Diff line change
`@@ -147,19 +147,19 @@`
`147`	`147`	`AUTH_PASSWORD_VALIDATORS = [`
`148`	`148`	`{`
`149`	`149`	`'NAME':`
`150`		`- 'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',`
	`150`	`+ 'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',`
`151`	`151`	`},`
`152`	`152`	`{`
`153`	`153`	`'NAME':`
`154`		`- 'django.contrib.auth.password_validation.MinimumLengthValidator',`
	`154`	`+ 'django.contrib.auth.password_validation.MinimumLengthValidator',`
`155`	`155`	`},`
`156`	`156`	`{`
`157`	`157`	`'NAME':`
`158`		`- 'django.contrib.auth.password_validation.CommonPasswordValidator',`
	`158`	`+ 'django.contrib.auth.password_validation.CommonPasswordValidator',`
`159`	`159`	`},`
`160`	`160`	`{`
`161`	`161`	`'NAME':`
`162`		`- 'django.contrib.auth.password_validation.NumericPasswordValidator',`
	`162`	`+ 'django.contrib.auth.password_validation.NumericPasswordValidator',`
`163`	`163`	`},`
`164`	`164`	`]`
`165`	`165`
`@@ -240,6 +240,7 @@`
`240`	`240`	`# Active Campaign Configuration`
`241`	`241`	`ACTIVE_CAMPAIGN_URL = config('ACTIVE_CAMPAIGN_URL')`
`242`	`242`	`ACTIVE_CAMPAIGN_KEY = config('ACTIVE_CAMPAIGN_KEY')`
	`243`	`+ACTIVE_CAMPAIGN_TURNED_ON = config('ACTIVE_CAMPAIGN_TURNED_ON', cast=bool, default=True)`
`243`	`244`
`244`	`245`	`# Google Tag Manager Configuration`
`245`	`246`	`GOOGLE_TAG_MANAGER_ID = config('GOOGLE_TAG_MANAGER_ID')`