Refactored Module method from url to get_absolut_url

renzon · renzon · commit 747e9fb5a4b0 · 2018-03-14T00:33:07.000-03:00
related to #45 This conforms to Django protocol for models
diff --git a/pythonpro/core/templates/core/base.html b/pythonpro/core/templates/core/base.html
@@ -29,7 +29,7 @@
           </a>
           <div class="dropdown-menu bg-dark border-light" aria-labelledby="navbarCourses">
             {% for module in ALL_MODULES %}
-              <a class="dropdown-item text-light" href="{{ module.url }}">{{ module.title }}</a>
+              <a class="dropdown-item text-light" href="{{ module.get_absolut_url }}">{{ module.title }}</a>
               {% if not forloop.last %}
                 <div class="dropdown-divider"></div>
               {% endif %}
diff --git a/pythonpro/modules/models/modules.py b/pythonpro/modules/models/modules.py
@@ -13,7 +13,7 @@ def __init__(self, title, slug, objective, description, target, *pre_requirement
         self.title = title
         ALL[self.slug] = self
 
-    def url(self):
+    def get_absolut_url(self):
         return reverse('modules:detail', kwargs={'slug': self.slug})
 
 
diff --git a/pythonpro/modules/templates/modules/module_detail.html b/pythonpro/modules/templates/modules/module_detail.html
@@ -14,7 +14,7 @@ <h1 class="mt-4 mb-3">{{ module.title }}</h1>
           <ul>
             {% for req_module in module.pre_requirements %}
               <li>
-                <a href="{{ module.url }}">{{ req_module.title }}</a>
+                <a href="{{ module.get_absolut_url }}">{{ req_module.title }}</a>
               </li>
 
             {% empty %}
diff --git a/pythonpro/modules/tests/test_module_index_view.py b/pythonpro/modules/tests/test_module_index_view.py
@@ -39,7 +39,7 @@ def test_module_index_link_not_logged(resp_not_logged):
 @modules_dec
 def test_module_link_not_logged(module: Module, resp_not_logged):
     """ Assert module links are not present when user is not logged """
-    dj_assert_not_contains(resp_not_logged, f'href="{module.url()}"')
+    dj_assert_not_contains(resp_not_logged, f'href="{module.get_absolut_url()}"')
 
 
 def test_module_index_link_logged(resp):
@@ -51,7 +51,7 @@ def test_module_index_link_logged(resp):
 @modules_dec
 def test_module_link_logged(module: Module, resp):
     """ Assert module links are present when user is logged """
-    dj_assert_contains(resp, f'href="{module.url()}"')
+    dj_assert_contains(resp, f'href="{module.get_absolut_url()}"')
 
 
 @modules_dec
