linting

moacirmoda · renzon · commit 403e64eeeee9 · 2019-11-20T23:40:44.000-03:00
diff --git a/pythonpro/analytics/migrations/0003_pageview.py b/pythonpro/analytics/migrations/0003_pageview.py
@@ -16,11 +16,24 @@ class Migration(migrations.Migration):
         migrations.CreateModel(
             name='PageView',
             fields=[
-                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('created', models.DateTimeField(default=django.utils.timezone.now, verbose_name='Criado em')),
-                ('updated', models.DateTimeField(auto_now=True, verbose_name='Alterado em')),
+                ('id',
+                 models.AutoField(auto_created=True,
+                                  primary_key=True,
+                                  serialize=False,
+                                  verbose_name='ID')),
+                ('created',
+                 models.DateTimeField(default=django.utils.timezone.now,
+                                      verbose_name='Criado em')),
+                ('updated',
+                 models.DateTimeField(auto_now=True,
+                                      verbose_name='Alterado em')),
                 ('meta', django.contrib.postgres.fields.jsonb.JSONField()),
-                ('session', models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, to='analytics.UserSession', verbose_name='sessão')),
+                ('session',
+                 models.ForeignKey(
+                     null=True,
+                     on_delete=django.db.models.deletion.SET_NULL,
+                     to='analytics.UserSession',
+                     verbose_name='sessão')),
             ],
             options={
                 'verbose_name': 'page view',
diff --git a/pythonpro/analytics/migrations/0004_usersession_user.py b/pythonpro/analytics/migrations/0004_usersession_user.py
@@ -16,6 +16,10 @@ class Migration(migrations.Migration):
         migrations.AddField(
             model_name='usersession',
             name='user',
-            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, to=settings.AUTH_USER_MODEL),
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                to=settings.AUTH_USER_MODEL),
         ),
     ]
diff --git a/pythonpro/analytics/models.py b/pythonpro/analytics/models.py
@@ -39,4 +39,4 @@ class Meta:
                                 verbose_name='sessão',
                                 on_delete=models.SET_NULL,
                                 null=True)
-    meta = JSONField()
+    meta = JSONField()
diff --git a/pythonpro/analytics/tests/facade/test_create_pageview.py b/pythonpro/analytics/tests/facade/test_create_pageview.py
@@ -1,11 +1,11 @@
 import pytest
-from model_mommy import mommy
 
 from pythonpro.analytics.models import PageView
 
 
 def test_should_facade_exists():
-    from pythonpro.analytics.facade import create_pageview
+    from pythonpro.analytics import facade
+    assert facade.create_pageview
 
 
 @pytest.fixture
@@ -47,7 +47,8 @@ def test_should_ignore_all_urls_that_starts_with_admin():
 
 
 @pytest.mark.django_db
-def test_should_call_is_to_save_this_pageview_function(mocked_request_with_analytics, mocker):
+def test_should_call_is_to_save_this_pageview_function(
+        mocked_request_with_analytics, mocker):
     from pythonpro.analytics.facade import create_pageview
 
     mocked = mocker.patch(
diff --git a/pythonpro/analytics/tests/facade/test_get_or_create_session.py b/pythonpro/analytics/tests/facade/test_get_or_create_session.py
@@ -1,12 +1,11 @@
 import pytest
 
-from django.test import Client
-
 from pythonpro.analytics.models import UserSession
 
 
 def test_should_exists_method():
-    from pythonpro.analytics.facade import get_or_create_session
+    from pythonpro.analytics import facade
+    assert facade.get_or_create_session
 
 
 @pytest.fixture
diff --git a/pythonpro/analytics/tests/test_middleware.py b/pythonpro/analytics/tests/test_middleware.py
@@ -2,7 +2,8 @@
 
 
 def test_should_assert_that_middleware_exists():
-    from pythonpro.analytics.middleware import AnalyticsMiddleware
+    from pythonpro.analytics import middleware
+    assert middleware.AnalyticsMiddleware
 
 
 @pytest.fixture
diff --git a/pythonpro/analytics/views.py b/pythonpro/analytics/views.py
