Refactored domain package to contains business rules

renzon · renzon · commit 3f067eb0c7bc · 2019-08-12T16:34:29.000-03:00
diff --git a/Pipfile.lock b/Pipfile.lock
diff --git a/pythonpro/core/tests/test_lead_landing_page.py b/pythonpro/core/tests/test_lead_landing_page.py
@@ -18,7 +18,7 @@ def test_status_code(resp):
 
 @pytest.fixture
 def create_lead_mock(mocker):
-    return mocker.patch('pythonpro.facade._mailchimp_facade.create_or_update_lead')
+    return mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.create_or_update_lead')
 
 
 @pytest.fixture
diff --git a/pythonpro/core/views.py b/pythonpro/core/views.py
@@ -9,7 +9,7 @@
 from django_sitemaps import Sitemap
 from rolepermissions.checkers import has_role
 
-from pythonpro import facade
+from pythonpro.domain import user_facade
 from pythonpro.core.forms import UserEmailForm, UserSignupForm
 from pythonpro.core.models import User
 
@@ -129,8 +129,8 @@ def lead_form(request):
     first_name = request.POST.get('first_name')
     email = request.POST.get('email')
     try:
-        user = facade.register_lead(first_name, email, source)
-    except facade.UserCreationException as e:
+        user = user_facade.register_lead(first_name, email, source)
+    except user_facade.UserCreationException as e:
         return render(request, 'core/lead_form_errors.html', context={'form': e.form})
     login(request, user)
     return redirect(reverse('core:lead_change_password'))
diff --git a/pythonpro/domain/README.md b/pythonpro/domain/README.md
@@ -0,0 +1 @@
+This package contains all facades containing entire application business rules (domain)
diff --git a/pythonpro/domain/__init__.py b/pythonpro/domain/__init__.py
diff --git a/pythonpro/domain/tests/__init__.py b/pythonpro/domain/tests/__init__.py
diff --git a/pythonpro/domain/tests/test_lead.py b/pythonpro/domain/tests/test_lead.py
@@ -1,14 +1,14 @@
 import pytest
 
-from pythonpro import facade
+from pythonpro.domain import user_facade
 
 
 @pytest.fixture
 def create_or_update_lead_mock(mocker):
-    return mocker.patch('pythonpro.facade._mailchimp_facade.create_or_update_lead')
+    return mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.create_or_update_lead')
 
 
 def test_creation(db, django_user_model, create_or_update_lead_mock):
-    user = facade.register_lead('Renzo Nuccitelli', 'renzo@python.pro.br', 'google_ads')
+    user = user_facade.register_lead('Renzo Nuccitelli', 'renzo@python.pro.br', 'google_ads')
     create_or_update_lead_mock.assert_called_once_with('Renzo Nuccitelli', 'renzo@python.pro.br')
     assert django_user_model.objects.all().get() == user
diff --git a/pythonpro/domain/tests/test_pytools_promotion.py b/pythonpro/domain/tests/test_pytools_promotion.py
@@ -5,58 +5,58 @@
 from model_mommy import mommy
 from rolepermissions.roles import assign_role
 
-from pythonpro import facade
+from pythonpro.domain import user_facade
 
 
 def test_leads_in_promotion_period(db, django_user_model, mocker):
     dts = (datetime(2019, 6, day, tzinfo=pytz.utc) for day in range(3, 10))
-    tag_as_mock = mocker.patch('pythonpro.facade._mailchimp_facade.tag_as')
+    tag_as_mock = mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.tag_as')
     users_created_seven_weeks_ago = [mommy.make(django_user_model, date_joined=d) for d in dts]
     for user in users_created_seven_weeks_ago:
         assign_role(user, 'lead')
     with freeze_time('2019-07-22'):
-        assert len(users_created_seven_weeks_ago) == facade.run_pytools_promotion_campaign()
+        assert len(users_created_seven_weeks_ago) == user_facade.run_pytools_promotion_campaign()
     for user in users_created_seven_weeks_ago:
         tag_as_mock.assert_any_call(user.email, 'pytools-promotion')
 
 
 def test_clients_not_marked_in_promotion_period(db, django_user_model, mocker):
     dts = (datetime(2019, 6, day, tzinfo=pytz.utc) for day in range(3, 10))
-    tag_as_mock = mocker.patch('pythonpro.facade._mailchimp_facade.tag_as')
+    tag_as_mock = mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.tag_as')
     users_created_seven_weeks_ago = [mommy.make(django_user_model, date_joined=d) for d in dts]
     for user in users_created_seven_weeks_ago:
         assign_role(user, 'client')
     with freeze_time('2019-07-22'):
-        assert 0 == facade.run_pytools_promotion_campaign()
+        assert 0 == user_facade.run_pytools_promotion_campaign()
     assert tag_as_mock.call_count == 0
 
 
 def test_members_not_marked_in_promotion_period(db, django_user_model, mocker):
     dts = (datetime(2019, 6, day, tzinfo=pytz.utc) for day in range(3, 10))
-    tag_as_mock = mocker.patch('pythonpro.facade._mailchimp_facade.tag_as')
+    tag_as_mock = mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.tag_as')
     users_created_seven_weeks_ago = [mommy.make(django_user_model, date_joined=d) for d in dts]
     for user in users_created_seven_weeks_ago:
         assign_role(user, 'client')
     with freeze_time('2019-07-22'):
-        assert 0 == facade.run_pytools_promotion_campaign()
+        assert 0 == user_facade.run_pytools_promotion_campaign()
     assert tag_as_mock.call_count == 0
 
 
 def test_before_promotion_period(db, django_user_model, mocker):
     dts = (datetime(2019, 6, day, tzinfo=pytz.utc) for day in range(1, 3))
-    tag_as_mock = mocker.patch('pythonpro.facade._mailchimp_facade.tag_as')
+    tag_as_mock = mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.tag_as')
     for d in dts:
         mommy.make(django_user_model, date_joined=d)
     with freeze_time('2019-07-22'):
-        assert 0 == facade.run_pytools_promotion_campaign()
+        assert 0 == user_facade.run_pytools_promotion_campaign()
     assert tag_as_mock.call_count == 0
 
 
 def test_after_promotion_period(db, django_user_model, mocker):
     dts = (datetime(2019, 6, day, tzinfo=pytz.utc) for day in range(10, 13))
-    tag_as_mock = mocker.patch('pythonpro.facade._mailchimp_facade.tag_as')
+    tag_as_mock = mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.tag_as')
     for d in dts:
         mommy.make(django_user_model, date_joined=d)
     with freeze_time('2019-07-22'):
-        assert 0 == facade.run_pytools_promotion_campaign()
+        assert 0 == user_facade.run_pytools_promotion_campaign()
     assert tag_as_mock.call_count == 0
diff --git a/pythonpro/domain/user_facade.py b/pythonpro/domain/user_facade.py
diff --git a/pythonpro/payments/management/commands/pytools_promotion.py b/pythonpro/payments/management/commands/pytools_promotion.py
@@ -1,6 +1,6 @@
 from django.core.management import BaseCommand
 
-from pythonpro import facade
+from pythonpro.domain import user_facade
 
 
 class Command(BaseCommand):
@@ -10,5 +10,5 @@ def add_arguments(self, parser):
         pass
 
     def handle(self, *args, **options):
-        promotion_users = facade.run_pytools_promotion_campaign()
+        promotion_users = user_facade.run_pytools_promotion_campaign()
         self.stdout.write(self.style.SUCCESS(f'Successfully marked {promotion_users} users for promotions'))
diff --git a/pythonpro/payments/tests/test_boleto_notification.py b/pythonpro/payments/tests/test_boleto_notification.py
@@ -21,7 +21,7 @@ def valid_signature():
 
 @pytest.fixture
 def create_or_update_client(client_with_lead, logged_user, mocker):
-    return mocker.patch('pythonpro.facade._mailchimp_facade.create_or_update_client')
+    return mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.create_or_update_client')
 
 
 @pytest.fixture
diff --git a/pythonpro/payments/tests/test_pagarme_boleto.py b/pythonpro/payments/tests/test_pagarme_boleto.py
@@ -131,12 +131,12 @@
 
 @pytest.fixture
 def create_or_update_client(mocker):
-    return mocker.patch('pythonpro.facade._mailchimp_facade.create_or_update_client')
+    return mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.create_or_update_client')
 
 
 @pytest.fixture
 def create_or_update_lead(mocker):
-    return mocker.patch('pythonpro.facade._mailchimp_facade.create_or_update_lead')
+    return mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.create_or_update_lead')
 
 
 @pytest.fixture
diff --git a/pythonpro/payments/tests/test_pagarme_credit_card.py b/pythonpro/payments/tests/test_pagarme_credit_card.py
@@ -141,12 +141,12 @@
 
 @pytest.fixture
 def create_or_update_client(mocker):
-    return mocker.patch('pythonpro.facade._mailchimp_facade.create_or_update_client')
+    return mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.create_or_update_client')
 
 
 @pytest.fixture
 def create_or_update_lead(mocker):
-    return mocker.patch('pythonpro.facade._mailchimp_facade.create_or_update_lead')
+    return mocker.patch('pythonpro.domain.user_facade._mailchimp_facade.create_or_update_lead')
 
 
 @pytest.fixture
diff --git a/pythonpro/payments/tests/test_pytools_promotion_cli.py b/pythonpro/payments/tests/test_pytools_promotion_cli.py
@@ -3,6 +3,6 @@
 
 def test_pytools_command(mocker):
     mock = mocker.patch(
-        'pythonpro.payments.management.commands.pytools_promotion.facade.run_pytools_promotion_campaign')
+        'pythonpro.payments.management.commands.pytools_promotion.user_facade.run_pytools_promotion_campaign')
     call_command('pytools_promotion')
     mock.assert_called_once_with()
diff --git a/pythonpro/payments/views.py b/pythonpro/payments/views.py
@@ -9,7 +9,7 @@
 from django.utils.timezone import now
 from django.views.decorators.csrf import csrf_exempt
 
-from pythonpro import facade
+from pythonpro.domain import user_facade
 from pythonpro.mailchimp.facade import tag_as
 from pythonpro.payments import facade as payment_facade
 from pythonpro.payments.facade import PYTOOLS_PRICE, PYTOOLS_PROMOTION_PRICE, PagarmeNotPaidTransaction
@@ -40,11 +40,11 @@ def pytools_capture(request):
         if user.is_authenticated:
             _promote_client(user, request)
         else:
-            facade.force_register_client(customer_first_name, customer_email, source)
+            user_facade.force_register_client(customer_first_name, customer_email, source)
         dct = {'redirect_url': reverse('payments:pytools_thanks')}
     elif payment_method == 'boleto':
         if not user.is_authenticated:
-            facade.force_register_lead(customer_first_name, customer_email, source)
+            user_facade.force_register_lead(customer_first_name, customer_email, source)
         path = reverse('payments:pytools_boleto')
         qs = urlencode(_extract_boleto_params(pagarme_resp))
         dct = {'redirect_url': f'{path}?{qs}'}
@@ -75,7 +75,7 @@ def _promote_client(user, request):
             'ty_url': request.build_absolute_uri(reverse('payments:pytools_thanks'))
         }
     )
-    facade.promote_client(user, msg)
+    user_facade.promote_client(user, msg)
 
 
 def pytools_thanks(request):
@@ -141,7 +141,7 @@ def pagarme_notification(request, user_id: int):
     except PagarmeNotPaidTransaction:
         pass  # No problem, we need to handle only paid transactions
     else:
-        user = facade.find_user_by_id(user_id)
+        user = user_facade.find_user_by_id(user_id)
         _promote_client(user, request)
     return HttpResponse('')
 
@@ -156,6 +156,6 @@ def pagarme_anonymous_notification(request):
     except PagarmeNotPaidTransaction:
         pass  # No problem, we need to handle only paid transactions
     else:
-        user = facade.find_user_by_email(transaction['customer']['email'])
+        user = user_facade.find_user_by_email(transaction['customer']['email'])
         _promote_client(user, request)
     return HttpResponse('')

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+This package contains all facades containing entire application business rules (domain)`