allowing link redirectior

moacirmoda · moacirmoda · commit 146daafe917b · 2020-04-23T09:22:02.000-03:00
diff --git a/pythonpro/redirector/admin.py b/pythonpro/redirector/admin.py
@@ -1,8 +1,15 @@
 from django.contrib import admin
 
-from pythonpro.redirector.models import Redirect
+from pythonpro.redirector.models import Redirect, RedirectLink
+
+
+class RedirectLinkAdmin(admin.TabularInline):
+    model = RedirectLink
+    extra = 1
+    readonly_fields = ['total_access', ]
 
 
 @admin.register(Redirect)
 class RedirectorAdmin(admin.ModelAdmin):
     list_display = 'slug url'.split()
+    inlines = (RedirectLinkAdmin, )
diff --git a/pythonpro/redirector/facade.py b/pythonpro/redirector/facade.py
@@ -1,5 +1,12 @@
+def _count_access_in_link(link):
+    link.total_access += 1
+    link.save()
+
+
 def get_redirect_url(redirect):
     if redirect.links.exists():
-        return redirect.links.order_by('?').first().url
+        link = redirect.links.order_by('total_access', 'id').first()
+        _count_access_in_link(link)
+        return link.url
 
     return redirect.url
diff --git a/pythonpro/redirector/migrations/0004_redirectlink_total_access.py b/pythonpro/redirector/migrations/0004_redirectlink_total_access.py
@@ -0,0 +1,18 @@
+# Generated by Django 3.0.4 on 2020-04-22 01:05
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('redirector', '0003_redirect_use_javascript'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='redirectlink',
+            name='total_access',
+            field=models.BigIntegerField(default=0),
+        ),
+    ]
diff --git a/pythonpro/redirector/models.py b/pythonpro/redirector/models.py
@@ -10,9 +10,13 @@ class Redirect(models.Model):
     url = models.URLField(null=True, blank=True)
     use_javascript = models.BooleanField(default=False)
 
+    def __str__(self):
+        return self.slug
+
 
 class RedirectLink(models.Model):
     created = models.DateTimeField("Criado em", default=timezone.now)
     updated = models.DateTimeField("Alterado em", auto_now=True)
     redirect = models.ForeignKey(Redirect, on_delete=models.PROTECT, related_name='links')
     url = models.URLField()
+    total_access = models.BigIntegerField(default=0)
diff --git a/pythonpro/redirector/tests/test_redirect_rotating_links.py b/pythonpro/redirector/tests/test_redirect_rotating_links.py
@@ -0,0 +1,49 @@
+import pytest
+from django.urls import reverse
+from model_mommy import mommy
+
+from pythonpro.django_assertions import dj_assert_contains
+from pythonpro.redirector.models import Redirect, RedirectLink
+from pythonpro.redirector.facade import get_redirect_url
+
+
+@pytest.fixture
+def redirect(db):
+    redirect = mommy.make(Redirect)
+    mommy.make(RedirectLink, redirect=redirect)
+    mommy.make(RedirectLink, redirect=redirect)
+    return redirect
+
+
+def test_should_get_url_and_increment_access_count(redirect):
+    url = get_redirect_url(redirect)
+    assert RedirectLink.objects.get(url=url, redirect=redirect).total_access == 1
+
+
+def test_should_bring_always_link_with_less_access(redirect):
+    link1 = redirect.links.first()
+    link2 = redirect.links.last()
+
+    link1.total_access = 2
+    link1.save()
+
+    assert get_redirect_url(redirect) == link2.url
+    assert get_redirect_url(redirect) == link2.url
+
+
+def test_should_bring_older_link_when_access_is_even(redirect):
+    assert get_redirect_url(redirect) == redirect.links.first().url
+
+
+@pytest.fixture
+def resp1(client, redirect):
+    return client.get(reverse('redirector:redirect', kwargs={'slug': redirect.slug}), secure=True)
+
+
+@pytest.fixture
+def resp2(client, redirect):
+    return client.get(reverse('redirector:redirect', kwargs={'slug': redirect.slug}), secure=True)
+
+
+def test_should_rotate_beetween_links(resp1, resp2):
+    assert resp1['Location'] != resp2['Location']
