Update setup.py for msbuild requirements #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbuild fix for vs2017 - do not specify msbuild version
Closed
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
========================================
- Coverage 77.05% 77% -0.05%
========================================
Files 63 63
Lines 5736 5741 +5
Branches 907 907
========================================
+ Hits 4420 4421 +1
- Misses 1017 1021 +4
Partials 299 299
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msbuild fix for vs2017 - do not specify msbuild version
What does this implement/fix? Explain your changes.
#720 (comment)
Does this close any currently open issues?
#720 (comment)
Any other comments?
ignore msbuild version, because errors out in vs 2017