Skip to content

Fix PyObject.GetHashCode - #677

Merged
filmor merged 2 commits into
pythonnet:masterfrom
GSPP:master
May 28, 2018
Merged

filmor merged 2 commits into
pythonnet:masterfrom
GSPP:master

Conversation

@GSPP

@GSPP GSPP commented May 27, 2018

Copy link
Copy Markdown

Fixes #676

@filmor

filmor commented May 27, 2018

Copy link
Copy Markdown
Member

Did you check that ulong's GetHashCode takes all bits into account? I can't find documentation on this, and apparently IntPtr.GetHashCode used to be broken in this regard.

@GSPP

GSPP commented May 28, 2018

Copy link
Copy Markdown
Author

I checked this with Reflector on .NET 4.7.2. Even if this is not working on lower versions, which I doubt for ulong, then the fix is still better than nothing. But it should be totally fine.

@filmor
filmor merged commit 06ded7a into pythonnet:master May 28, 2018
@filmor

filmor commented May 28, 2018

Copy link
Copy Markdown
Member

Cool, thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants