Skip to content

[WIP] handling ByRef arguments for method overloading - update methodbinder.cs #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
den-run-ai wants to merge 1 commit into from
Closed

[WIP] handling ByRef arguments for method overloading - update methodbinder.cs #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/runtime/methodbinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,9 +344,13 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw,
if (clrtype != null)
{
bool typematch = false;
if (pi[n].ParameterType != clrtype)
Type paramtype = pi[n].ParameterType;
if (pi[n].ParameterType.IsByRef) {
paramtype = pi[n].ParameterType.GetElementType();
}
if (paramtype != clrtype)
{
IntPtr pytype = Converter.GetPythonTypeByAlias(pi[n].ParameterType);
IntPtr pytype = Converter.GetPythonTypeByAlias(paramtype);
pyoptype = Runtime.PyObject_Type(op);
Exceptions.Clear();
if (pyoptype != IntPtr.Zero)
Expand All @@ -364,7 +368,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw,
if (!typematch)
{
// this takes care of enum values
TypeCode argtypecode = Type.GetTypeCode(pi[n].ParameterType);
TypeCode argtypecode = Type.GetTypeCode(paramtype);
TypeCode paramtypecode = Type.GetTypeCode(clrtype);
if (argtypecode == paramtypecode)
{
Expand Down Expand Up @@ -603,4 +607,4 @@ internal Binding(MethodBase info, Object inst, Object[] args,
this.outs = outs;
}
}
}
}