fixing VS solution - compilation symbol is used for detect which interop**.cs to use#169
Closed
den-run-ai wants to merge 9 commits intopythonnet:developfrom
Closed
fixing VS solution - compilation symbol is used for detect which interop**.cs to use#169den-run-ai wants to merge 9 commits intopythonnet:developfrom
den-run-ai wants to merge 9 commits intopythonnet:developfrom
Conversation
Contributor
|
This PR doesn't meet the guidelines set out in contributing.md. In addition, this will not work when the abi flags are different (eg a debug build of Python). The solution of doing a string replace seems inelegant to me. Commenting out code the should be deleted is something I've mentioned before I think; I'll add a point about that to the contrib file. |
Contributor
Author
BTW, the clrmodule project (which compiles to clr.pyd) does not have synchronized python version flag with |
Contributor
I'm closing this PR. I will do the necessary changes myself when I have time. |
Contributor
|
See PR #171. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patches geninterop.py to output compilation symbon conditional, includes all interop**.cs to solution