Removed unnecessary dictionary initialization in CLRObject#1413
Closed
lostmsu wants to merge 0 commit intopythonnet:masterfrom
Closed
Removed unnecessary dictionary initialization in CLRObject#1413lostmsu wants to merge 0 commit intopythonnet:masterfrom
lostmsu wants to merge 0 commit intopythonnet:masterfrom
Conversation
lostmsu
force-pushed
the
dont-alloc-dict-for-clrobject
branch
from
66ddf97 to
db746aa
Compare
Member
Author
|
Superseded by #1441 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see any reason for it to be present. The code does not have any associated comments, and I was not able to hit it running our tests. Any proper access to
ob_dictshould be going throughPyObject_GenericGetDict, which initializesob_dictif necessary.