Skip to content

Use .NET Core 3.1 LTS for tests (instead of 2.0)#1279

Merged
lostmsu merged 1 commit intopythonnet:masterfrom
losttech:update/NetCore21
Nov 13, 2020
Merged

Use .NET Core 3.1 LTS for tests (instead of 2.0)#1279
lostmsu merged 1 commit intopythonnet:masterfrom
losttech:update/NetCore21

Conversation

@lostmsu
Copy link
Copy Markdown
Member

@lostmsu lostmsu commented Nov 12, 2020

What does this implement/fix? Explain your changes.

.NET Core 2.0 is no longer supported. This moves tests to .NET Core 3.1 LTS, which should be supported until Dec 2022.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 12, 2020

Codecov Report

Merging #1279 (13694d6) into master (d0c588b) will increase coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
+ Coverage   86.25%   87.62%   +1.37%     
==========================================
  Files           1        1              
  Lines         291      291              
==========================================
+ Hits          251      255       +4     
+ Misses         40       36       -4     
Flag Coverage Δ
setup_linux 64.94% <ø> (ø)
setup_windows 73.88% <ø> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 87.62% <ø> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c588b...13694d6. Read the comment docs.

@lostmsu
Copy link
Copy Markdown
Member Author

lostmsu commented Nov 13, 2020

Travis actually passed, but for some reason was not recorded correctly: https://travis-ci.org/github/pythonnet/pythonnet/builds/743309873

Since there are no functional changes, and tests still pass, I am going to merge this.

@lostmsu lostmsu merged commit 36bdb98 into pythonnet:master Nov 13, 2020
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.62%. Comparing base (d0c588b) to head (13694d6).
⚠️ Report is 758 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
+ Coverage   86.25%   87.62%   +1.37%     
==========================================
  Files           1        1              
  Lines         291      291              
==========================================
+ Hits          251      255       +4     
+ Misses         40       36       -4     
Flag Coverage Δ
setup_linux 64.94% <ø> (ø)
setup_windows 73.88% <ø> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants