Require at least .NET 4.7.1 #897

Activity

1. filmor

   added

   rfc

   on Jun 26, 2019
2. Cronan commented on Jun 26, 2019

   

   Cronan

   on Jun 26, 2019

   Contributor

   More actions

   I think this is a really good idea - I'm trying to target 4.7.2 in general because of this - https://docs.microsoft.com/en-us/dotnet/standard/net-standard
3. amos402 commented on Jun 26, 2019

   

   amos402

   on Jun 26, 2019

   Member

   More actions

   I'd like to upgrade to 4.7, so as we can improve some interface's performance simply.
   For example GetManagedString

                   IntPtr p = PyUnicode_AsUnicode(op);
                   int length = (int)PyUnicode_GetSize(op);
   #if NET46 || NET_4_6
                   unsafe
                   {
                       return PyEncoding.GetString((byte*)p, length * _UCS);
                   }
   #else
                   int size = length * _UCS;
                   var buffer = new byte[size];
                   Marshal.Copy(p, buffer, 0, size);
                   return PyEncoding.GetString(buffer, 0, size);
   #endif

   That make avoiding a memory copy.
4. benoithudson commented on Dec 13, 2019

   

   benoithudson

   on Dec 13, 2019

   Contributor

   More actions

   Should we make a decision on this next meeting, so people have a deadline to object?

   I'm in favour.
5. filmor commented on Jun 10, 2020

   

   filmor

   on Jun 10, 2020

   MemberAuthor

   More actions

   This is decided, we will use .NET Standard 2.0 (so at least .NET Framework 4.7.2) in version 3.
6. filmor

   closed this as completedon Jun 10, 2020