Skip to content

PythonEngine.AcquireLock and ReleaseLock are marked "internal", but are mentioned in the documentation #2091

Closed

Description

@koubaa

Environment

  • Pythonnet version: 3.x

Details

This document refers to the internal implementation details AcquireLock & ReleaseLock.

If these are meant to be used from C# code, these should be made public again. If not - they should be removed from the document (imho).

FWIW I use them in my code (but I can directly call into python3.x.dll for PyGILState_Ensure if they are not meant to be exposed by pythonnet)

Activity

  1. lostmsu commented on Jan 25, 2023

    @lostmsu
    Member

    You should be using Py.GIL and its Dispose instead.

  2. koubaa commented on Jan 25, 2023

    @koubaa
    ContributorAuthor

    That's what I was thinking right after I sent this - these two functions are an unsafe way to do the same thing.. in any case the document should be updated

  3. added a commit that references this issue on Jan 26, 2023
    1dc3c1c
  4. added a commit that references this issue on Jan 29, 2023
    c2fa467
  5. added a commit that references this issue on Feb 17, 2023
    e39260f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions