Should Python.Runtime.Py.With use Runtime.None instead of new PyObject(Runtime.PyNone)? #1192

Activity

1. IvanAntipov commented on Jul 30, 2020

   

   IvanAntipov

   on Jul 30, 2020

   Last edited by IvanAntipov

   Author

   More actions

   The proble with "delallocating None" has gone, after I have switched to my own implmetation of "Py.With"

   F# code:

       let inline pyWith(pyObj: PyObject, func: PyObject -> 'T) =
           let mutable ptr: PyObject option = None // this is F# None, in C# implementation you can use ``null`` instead 
           let mutable ptr2: PyObject option = None // this is F# None
           let mutable ptr3: PyObject option = None // this is F# None
           let mutable ex : PythonException = null;
           let mutable res : 'T option = None // this is F# None
   
           try 
               let obj2: PyObject = pyObj.InvokeMethod("__enter__");
               
               res <- Some <| func(obj2)
           with
           | :? PythonException as ex2 ->            
               ex <- ex2;
               ptr <- Some <| PyObject ex.PyType
               ptr2 <- Some <| PyObject ex.PyValue;
               ptr3 <- Some <| PyObject ex.PyTB;
   
           let toPyNoneIfEmpty(o: PyObject option) = o |> Option.defaultWith(fun () -> Runtime.GetPyNone()) // Runtime.GetPyNone() pythonnet_standard alternative of Py.None
   
           let exitObject : PyObject = pyObj.InvokeMethod("__exit__", ptr |> toPyNoneIfEmpty, ptr |> toPyNoneIfEmpty, ptr2 |> toPyNoneIfEmpty, ptr3 |> toPyNoneIfEmpty);
           
           if (ex |> isNull |> not && not <| exitObject.IsTrue()) then
               raise ex
   
           res |> Option.get
2. lostmsu commented on Jul 30, 2020

   

   lostmsu

   on Jul 30, 2020

   Last edited by lostmsu

   Member

   More actions

   @IvanAntipov this has already been fixed before 2.5.0 was released in #1062. The very link you provided to this repo has XIncref(type) just a few lines above new PyObject(type).

   👍React with 👍1Reacted by IvanAntipov
3. lostmsu

   closed this as completedon Jul 30, 2020