Rename Copy to NewReference

filmor · filmor · commit ec0a4942e913 · 2026-05-12T18:21:05.000+02:00
diff --git a/src/runtime/PythonTypes/PyObject.cs b/src/runtime/PythonTypes/PyObject.cs
@@ -93,7 +93,7 @@ internal PyObject(in StolenReference reference)
             Finalizer.Instance.ThrottledCollect();
         }
 
-        public PyObject Copy() => new(this);
+        public PyObject NewReference() => new(this);
 
         // Ensure that encapsulated Python object is decref'ed appropriately
         // when the managed wrapper is garbage-collected.
diff --git a/src/runtime/PythonTypes/PyType.cs b/src/runtime/PythonTypes/PyType.cs
@@ -35,7 +35,7 @@ internal PyType(in StolenReference reference, bool prevalidated = false) : base(
                 throw new ArgumentException("object is not a type");
         }
 
-        public new PyType Copy() => new(this);
+        public new PyType NewReference() => new(this);
 
         protected PyType(SerializationInfo info, StreamingContext context) : base(info, context) { }
 
diff --git a/src/runtime/Types/MethodBinding.cs b/src/runtime/Types/MethodBinding.cs
@@ -52,7 +52,7 @@ public static NewReference mp_subscript(BorrowedReference tp, BorrowedReference
             }
 
             MethodObject overloaded = self.m.WithOverloads(overloads);
-            var mb = new MethodBinding(overloaded, self.target?.Copy(), self.targetType.Copy());
+            var mb = new MethodBinding(overloaded, self.target?.NewReference(), self.targetType.NewReference());
             return mb.Alloc();
         }
 
@@ -139,7 +139,7 @@ public static NewReference tp_getattro(BorrowedReference ob, BorrowedReference k
                 // FIXME: deprecate __overloads__ soon...
                 case "__overloads__":
                 case "Overloads":
-                    var om = new OverloadMapper(self.m, self.target?.Copy(), self.targetType.Copy());
+                    var om = new OverloadMapper(self.m, self.target?.NewReference(), self.targetType.NewReference());
                     return om.Alloc();
                 case "__signature__" when Runtime.InspectModule is not null:
                     var sig = self.Signature;
diff --git a/src/runtime/Types/OverloadMapper.cs b/src/runtime/Types/OverloadMapper.cs
@@ -44,7 +44,7 @@ public static NewReference mp_subscript(BorrowedReference tp, BorrowedReference
                 return Exceptions.RaiseTypeError(e);
             }
 
-            var mb = new MethodBinding(self.m, self.target?.Copy(), self.targetType.Copy()) { info = mi };
+            var mb = new MethodBinding(self.m, self.target?.NewReference(), self.targetType.NewReference()) { info = mi };
             return mb.Alloc();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ internal PyObject(in StolenReference reference)`
`93`	`93`	`Finalizer.Instance.ThrottledCollect();`
`94`	`94`	`}`
`95`	`95`
`96`		`- public PyObject Copy() => new(this);`
	`96`	`+ public PyObject NewReference() => new(this);`
`97`	`97`
`98`	`98`	`// Ensure that encapsulated Python object is decref'ed appropriately`
`99`	`99`	`// when the managed wrapper is garbage-collected.`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ internal PyType(in StolenReference reference, bool prevalidated = false) : base(`
`35`	`35`	`throw new ArgumentException("object is not a type");`
`36`	`36`	`}`
`37`	`37`
`38`		`- public new PyType Copy() => new(this);`
	`38`	`+ public new PyType NewReference() => new(this);`
`39`	`39`
`40`	`40`	`protected PyType(SerializationInfo info, StreamingContext context) : base(info, context) { }`
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public static NewReference mp_subscript(BorrowedReference tp, BorrowedReference`
`44`	`44`	`return Exceptions.RaiseTypeError(e);`
`45`	`45`	`}`
`46`	`46`
`47`		`- var mb = new MethodBinding(self.m, self.target?.Copy(), self.targetType.Copy()) { info = mi };`
	`47`	`+ var mb = new MethodBinding(self.m, self.target?.NewReference(), self.targetType.NewReference()) { info = mi };`
`48`	`48`	`return mb.Alloc();`
`49`	`49`	`}`
`50`	`50`