Use informational version as clr's __version__ attribute

filmor · filmor · commit d48479703ed4 · 2022-07-08T17:33:28.000+02:00
diff --git a/src/runtime/PythonEngine.cs b/src/runtime/PythonEngine.cs
@@ -228,6 +228,7 @@ public static void Initialize(IEnumerable<string> args, bool setSysArgv = true,
                 Assembly assembly = Assembly.GetExecutingAssembly();
                 // add the contents of clr.py to the module
                 string clr_py = assembly.ReadStringResource("clr.py");
+
                 Exec(clr_py, module_globals, locals.Reference);
 
                 LoadSubmodule(module_globals, "clr.interop", "interop.py");
@@ -237,14 +238,22 @@ public static void Initialize(IEnumerable<string> args, bool setSysArgv = true,
                 // add the imported module to the clr module, and copy the API functions
                 // and decorators into the main clr module.
                 Runtime.PyDict_SetItemString(clr_dict, "_extras", module);
+
+                // append version
+                var version = typeof(PythonEngine)
+                    .Assembly
+                    .GetCustomAttribute<AssemblyInformationalVersionAttribute>()
+                    .InformationalVersion;
+                using var versionObj = Runtime.PyString_FromString(version);
+                Runtime.PyDict_SetItemString(clr_dict, "__version__", versionObj.Borrow());
+
                 using var keys = locals.Keys();
                 foreach (PyObject key in keys)
                 {
-                    if (!key.ToString()!.StartsWith("_") || key.ToString()!.Equals("__version__"))
+                    if (!key.ToString()!.StartsWith("_"))
                     {
-                        PyObject value = locals[key];
+                        using PyObject value = locals[key];
                         Runtime.PyDict_SetItem(clr_dict, key.Reference, value.Reference);
-                        value.Dispose();
                     }
                     key.Dispose();
                 }
diff --git a/src/runtime/Resources/clr.py b/src/runtime/Resources/clr.py
@@ -2,8 +2,6 @@
 Code in this module gets loaded into the main clr module.
 """
 
-__version__ = "3.0.0dev"
-
 
 class clrproperty(object):
     """
