Enable TestPyTupleInvalidAppend test

vmuriart · vmuriart · commit cef615317035 · 2017-02-26T18:38:44.000-07:00
`AppDomain unload` was solved by #400. Closes #397. Possibly also solved #245.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -47,6 +47,7 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].
 -   Fixed wrong version number in `conda.recipe` (#398)
 -   Fixed fixture location for Python tests and `Embedded_Tests`
 -   Fixed `PythonException` crash during Shutdown (#400)
+-   Fixed `AppDomain` unload during GC (#397)(#400)
 -   Fixed `Py_Main` & `PySys_SetArgvEx` no mem error on `UCS4/PY3` (#399)
 
 ### Removed
diff --git a/src/embed_tests/dynamic.cs b/src/embed_tests/dynamic.cs
@@ -68,8 +68,6 @@ public void AssignPyObject()
             if (Environment.GetEnvironmentVariable("TRAVIS") == "true" &&
                 Environment.GetEnvironmentVariable("TRAVIS_PYTHON_VERSION") == "2.7")
             {
-                // Most recently threw `auto-releasing thread-state, but no thread-state for this thread`
-                // instead of the error below. Maybe had bad mapping to library?
                 Assert.Ignore("Fails on Travis/PY27: ImportError: ... undefined symbol: _PyLong_AsInt");
             }
 
@@ -84,9 +82,6 @@ public void AssignPyObject()
         /// <summary>
         /// Pass the .NET object in Python side.
         /// </summary>
-        /// <remarks>
-        /// FIXME: Possible source of intermittent Travis PY27: Unable to unload AppDomain.
-        /// </remarks>
         [Test]
         public void PassObjectInPython()
         {
diff --git a/src/embed_tests/pytuple.cs b/src/embed_tests/pytuple.cs
@@ -10,10 +10,6 @@ public class PyTupleTest
         /// Test IsTupleType without having to Initialize a tuple.
         /// PyTuple constructor use IsTupleType. This decouples the tests.
         /// </summary>
-        /// <remarks>
-        /// Travis PY27 intermittently fails this test. Indicates issue is
-        /// most likely with PyTuple.IsTupleType
-        /// </remarks>
         [Test]
         public void TestStringIsTupleType()
         {
@@ -47,15 +43,16 @@ public void TestPyTupleEmpty()
             }
         }
 
+        /// <summary>
+        /// Test PyTuple.Concat(...) doesn't let invalid appends happen
+        /// and throws and exception.
+        /// </summary>
         /// <remarks>
-        /// FIXME: Unable to unload AppDomain, Unload thread timed out.
-        /// Seen on Travis/AppVeyor on both PY2 and PY3. Causes Embedded_Tests
-        /// to hang after they are finished for ~40 seconds until nunit3 forces
-        /// a timeout on unloading tests. Doesn't fail the tests though but
-        /// greatly slows down CI. nunit2 silently has this issue.
+        /// Test has second purpose. Currently it generated an Exception
+        /// that the GC failed to remove often and caused AppDomain unload
+        /// errors at the end of tests. See GH#397 for more info.
         /// </remarks>
         [Test]
-        [Ignore("GH#397: Travis/AppVeyor: Unable to unload AppDomain, Unload thread timed out")]
         public void TestPyTupleInvalidAppend()
         {
             using (Py.GIL())
@@ -106,10 +103,6 @@ public void TestPyTupleValidConvert()
             }
         }
 
-        /// <remarks>
-        /// FIXME: Possible source of intermittent AppVeyor PY27: Unable to unload AppDomain.
-        /// FIXME: Intermittent Issue on Travis PY33: Fatal Python error: PyMUTEX_LOCK(gil_mutex) failed. Seen twice.
-        /// </remarks>
         [Test]
         public void TestNewPyTupleFromPyTuple()
         {
diff --git a/src/runtime/pythonexception.cs b/src/runtime/pythonexception.cs
@@ -135,6 +135,8 @@ public override string StackTrace
         /// <remarks>
         /// The Dispose method provides a way to explicitly release the
         /// Python objects represented by a PythonException.
+        /// If object not properly disposed can cause AppDomain unload issue.
+        /// See GH#397 and GH#400.
         /// </remarks>
         public void Dispose()
         {

Original file line number	Diff line number	Diff line change
`@@ -68,8 +68,6 @@ public void AssignPyObject()`
`68`	`68`	`if (Environment.GetEnvironmentVariable("TRAVIS") == "true" &&`
`69`	`69`	`Environment.GetEnvironmentVariable("TRAVIS_PYTHON_VERSION") == "2.7")`
`70`	`70`	`{`
`71`		- // Most recently threw `auto-releasing thread-state, but no thread-state for this thread`
`72`		`- // instead of the error below. Maybe had bad mapping to library?`
`73`	`71`	`Assert.Ignore("Fails on Travis/PY27: ImportError: ... undefined symbol: _PyLong_AsInt");`
`74`	`72`	`}`
`75`	`73`
`@@ -84,9 +82,6 @@ public void AssignPyObject()`
`84`	`82`	`/// <summary>`
`85`	`83`	`/// Pass the .NET object in Python side.`
`86`	`84`	`/// </summary>`
`87`		`- /// <remarks>`
`88`		`- /// FIXME: Possible source of intermittent Travis PY27: Unable to unload AppDomain.`
`89`		`- /// </remarks>`
`90`	`85`	`[Test]`
`91`	`86`	`public void PassObjectInPython()`
`92`	`87`	`{`
Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,8 @@ public override string StackTrace`
`135`	`135`	`/// <remarks>`
`136`	`136`	`/// The Dispose method provides a way to explicitly release the`
`137`	`137`	`/// Python objects represented by a PythonException.`
	`138`	`+ /// If object not properly disposed can cause AppDomain unload issue.`
	`139`	`+ /// See GH#397 and GH#400.`
`138`	`140`	`/// </remarks>`
`139`	`141`	`public void Dispose()`
`140`	`142`	`{`