give users some idea of why we might be unable to reflect .NET types to Python for them

lostmsu · lostmsu · commit c60d2503b8a6 · 2024-07-01T15:02:01.000-07:00
diff --git a/src/runtime/InternalPythonnetException.cs b/src/runtime/InternalPythonnetException.cs
@@ -0,0 +1,9 @@
+using System;
+
+namespace Python.Runtime;
+
+public class InternalPythonnetException : Exception
+{
+    public InternalPythonnetException(string message, Exception innerException)
+        : base(message, innerException) { }
+}
diff --git a/src/runtime/Types/ReflectedClrType.cs b/src/runtime/Types/ReflectedClrType.cs
@@ -30,22 +30,29 @@ public static ReflectedClrType GetOrCreate(Type type)
             return pyType;
         }
 
-        // Ensure, that matching Python type exists first.
-        // It is required for self-referential classes
-        // (e.g. with members, that refer to the same class)
-        pyType = AllocateClass(type);
-        ClassManager.cache.Add(type, pyType);
+        try
+        {
+            // Ensure, that matching Python type exists first.
+            // It is required for self-referential classes
+            // (e.g. with members, that refer to the same class)
+            pyType = AllocateClass(type);
+            ClassManager.cache.Add(type, pyType);
 
-        var impl = ClassManager.CreateClass(type);
+            var impl = ClassManager.CreateClass(type);
 
-        TypeManager.InitializeClassCore(type, pyType, impl);
+            TypeManager.InitializeClassCore(type, pyType, impl);
 
-        ClassManager.InitClassBase(type, impl, pyType);
+            ClassManager.InitClassBase(type, impl, pyType);
 
-        // Now we force initialize the Python type object to reflect the given
-        // managed type, filling the Python type slots with thunks that
-        // point to the managed methods providing the implementation.
-        TypeManager.InitializeClass(pyType, impl, type);
+            // Now we force initialize the Python type object to reflect the given
+            // managed type, filling the Python type slots with thunks that
+            // point to the managed methods providing the implementation.
+            TypeManager.InitializeClass(pyType, impl, type);
+        }
+        catch (Exception e)
+        {
+            throw new InternalPythonnetException($"Failed to create Python type for {type.FullName}", e);
+        }
 
         return pyType;
     }
