insert memory barriers to ensure main thread does not read stale values in TestThread

lostmsu · lostmsu · commit 8a59713e5094 · 2022-05-02T17:11:29.000-07:00
diff --git a/src/embed_tests/Modules.cs b/src/embed_tests/Modules.cs
@@ -347,6 +347,7 @@ public void TestThread()
                         {
                             //ps.GetVariable<dynamic>("update")(); //call the scope function dynamicly
                             _ps.update();
+                            Thread.MemoryBarrier();
                         }
                     });
                     th.Start();
@@ -357,12 +358,14 @@ public void TestThread()
                 {
                     using (Py.GIL())
                     {
+                        Thread.MemoryBarrier();
                         cnt = ps.Get<int>("th_cnt");
                     }
                     Thread.Yield();
                 }
                 using (Py.GIL())
                 {
+                    Thread.MemoryBarrier();
                     var result = ps.Get<int>("res");
                     Assert.AreEqual(101 * th_cnt, result);
                 }

Original file line number	Diff line number	Diff line change
`@@ -347,6 +347,7 @@ public void TestThread()`
`347`	`347`	`{`
`348`	`348`	`//ps.GetVariable<dynamic>("update")(); //call the scope function dynamicly`
`349`	`349`	`_ps.update();`
	`350`	`+ Thread.MemoryBarrier();`
`350`	`351`	`}`
`351`	`352`	`});`
`352`	`353`	`th.Start();`
`@@ -357,12 +358,14 @@ public void TestThread()`
`357`	`358`	`{`
`358`	`359`	`using (Py.GIL())`
`359`	`360`	`{`
	`361`	`+ Thread.MemoryBarrier();`
`360`	`362`	`cnt = ps.Get<int>("th_cnt");`
`361`	`363`	`}`
`362`	`364`	`Thread.Yield();`
`363`	`365`	`}`
`364`	`366`	`using (Py.GIL())`
`365`	`367`	`{`
	`368`	`+ Thread.MemoryBarrier();`
`366`	`369`	`var result = ps.Get<int>("res");`
`367`	`370`	`Assert.AreEqual(101 * th_cnt, result);`
`368`	`371`	`}`