Try to guess the correct element type from an enumerator, use in conversion

filmor · filmor · commit 6e202f636f4f · 2019-09-27T08:08:05.000+02:00
diff --git a/src/runtime/converter.cs b/src/runtime/converter.cs
@@ -155,7 +155,7 @@ internal static IntPtr ToPython(object value, Type type)
             // type is. we'd rather have the object bound to the actual
             // implementing class.
 
-            type = value.GetType();
+            type = type ?? value.GetType();
 
             TypeCode tc = Type.GetTypeCode(type);
 
diff --git a/src/runtime/iterator.cs b/src/runtime/iterator.cs
@@ -1,5 +1,7 @@
+using System.Linq;
 using System;
 using System.Collections;
+using System.Collections.Generic;
 
 namespace Python.Runtime
 {
@@ -10,10 +12,17 @@ namespace Python.Runtime
     internal class Iterator : ExtensionType
     {
         private IEnumerator iter;
+        private Type type;
 
         public Iterator(IEnumerator e)
         {
             iter = e;
+
+            var genericType = e.GetType().GetInterfaces().FirstOrDefault(
+                x => x.IsGenericType && x.GetGenericTypeDefinition() == typeof(Generic.IEnumerator<>)
+            );
+
+            type = genericType?.GetGenericArguments().FirstOrDefault();
         }
 
 
@@ -41,7 +50,7 @@ public static IntPtr tp_iternext(IntPtr ob)
                 return IntPtr.Zero;
             }
             object item = self.iter.Current;
-            return Converter.ToPythonImplicit(item);
+            return Converter.ToPython(item, type);
         }
 
         public static IntPtr tp_iter(IntPtr ob)

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
	`1`	`+using System.Linq;`
`1`	`2`	`using System;`
`2`	`3`	`using System.Collections;`
	`4`	`+using System.Collections.Generic;`
`3`	`5`
`4`	`6`	`namespace Python.Runtime`
`5`	`7`	`{`
`@@ -10,10 +12,17 @@ namespace Python.Runtime`
`10`	`12`	`internal class Iterator : ExtensionType`
`11`	`13`	`{`
`12`	`14`	`private IEnumerator iter;`
	`15`	`+ private Type type;`
`13`	`16`
`14`	`17`	`public Iterator(IEnumerator e)`
`15`	`18`	`{`
`16`	`19`	`iter = e;`
	`20`	`+`
	`21`	`+ var genericType = e.GetType().GetInterfaces().FirstOrDefault(`
	`22`	`+ x => x.IsGenericType && x.GetGenericTypeDefinition() == typeof(Generic.IEnumerator<>)`
	`23`	`+ );`
	`24`	`+`
	`25`	`+ type = genericType?.GetGenericArguments().FirstOrDefault();`
`17`	`26`	`}`
`18`	`27`
`19`	`28`
`@@ -41,7 +50,7 @@ public static IntPtr tp_iternext(IntPtr ob)`
`41`	`50`	`return IntPtr.Zero;`
`42`	`51`	`}`
`43`	`52`	`object item = self.iter.Current;`
`44`		`- return Converter.ToPythonImplicit(item);`
	`53`	`+ return Converter.ToPython(item, type);`
`45`	`54`	`}`
`46`	`55`
`47`	`56`	`public static IntPtr tp_iter(IntPtr ob)`