Skip to content

Commit fd7da1e

Browse files
author
Josh Hoyt
committed
[project @ Fix implementation of association message signing]
1 parent 9e2b54c commit fd7da1e

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

‎openid/association.py‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -454,11 +454,17 @@ def signMessage(self, message):
454454
message.hasKey(OPENID_NS, 'signed')):
455455
raise ValueError('Message already has signed list or signature')
456456

457+
extant_handle = message.getArg(OPENID_NS, 'assoc_handle')
458+
if extant_handle and extant_handle != self.handle:
459+
raise ValueError("Message has a different association handle")
460+
457461
signed_message = message.copy()
458-
args = message.toPostArgs()
459-
signed_list = [k[7:] for k in args if k.startswith('openid.')]
462+
signed_message.setArg(OPENID_NS, 'assoc_handle', self.handle)
463+
message_keys = signed_message.toPostArgs().keys()
464+
signed_list = [k[7:] for k in message_keys if k.startswith('openid.')]
460465
signed_list.append('signed')
461-
signed_message.setArg(OPENID_NS, 'signed', ','.join(signed))
466+
signed_list.sort()
467+
signed_message.setArg(OPENID_NS, 'signed', ','.join(signed_list))
462468
sig = self.getMessageSignature(signed_message)
463469
signed_message.setArg(OPENID_NS, 'sig', sig)
464470
return signed_message

0 commit comments

Comments
 (0)