Skip to content

Commit efe02df

Browse files
author
Kevin Turner
committed
[project @ association.Association._makePairsSignAll: added]
actually, seems to have snuck in in a previous patch, but here's the test.
1 parent 6622e34 commit efe02df

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

‎openid/association.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,7 @@ def checkMessageSignature(self, message):
453453

454454
def _makePairsSignAll(self, message):
455455
pairs = message.toPostArgs().items()
456+
pairs.sort()
456457
return pairs
457458

458459

‎openid/test/test_association.py‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,17 @@ def testMakePairsSignedList(self):
9898
self.failUnlessEqual(pairs, expected)
9999

100100

101+
def testMakePairsSignAll(self):
102+
pairs = self.assoc._makePairsSignAll(self.message)
103+
expected = [
104+
('openid.identifier', '=example'),
105+
('openid.mode', 'id_res'),
106+
('openid.ns', 'http://openid.net/specs/2.0/base'),
107+
('openid.signed', 'identifier,mode'),
108+
('xey', 'value'),
109+
]
110+
self.failUnlessEqual(pairs, expected)
111+
101112

102113
def pyUnitTests():
103114
return datadriven.loadTests(__name__)

0 commit comments

Comments
 (0)