Skip to content

Commit d7e57b4

Browse files
author
Kevin Turner
committed
[project @ test_server.TestProtocolError: test hasReturnTo() when message=None.]
We had a "if False is not None" in ProtocolError.hasReturnTo.
1 parent 374167a commit d7e57b4

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

‎openid/server/server.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1596,7 +1596,7 @@ def getReturnTo(self):
15961596
@returntype: str
15971597
"""
15981598
if self.openid_message is None:
1599-
return False
1599+
return None
16001600
else:
16011601
return self.openid_message.getArg(OPENID_NS, 'return_to')
16021602

‎openid/test/test_server.py‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,11 @@ def test_noReturnTo(self):
132132
self.failUnlessEqual(e.encodeToKVForm(), expected)
133133

134134

135+
def test_noMessage(self):
136+
e = server.ProtocolError(None, "no moar pancakes")
137+
self.failIf(e.hasReturnTo())
138+
self.failUnlessEqual(e.whichEncoding(), None)
139+
135140

136141
class TestDecode(unittest.TestCase):
137142
def setUp(self):

0 commit comments

Comments
 (0)