@@ -259,6 +259,63 @@ def gotLogMessage(self, message):
259259 def tearDown (self ):
260260 oidutil .log = self .old_logger
261261
262+ class NonceIdResTest (TestIdRes ):
263+ def setUp (self ):
264+ self .old_logger = oidutil .log
265+ oidutil .log = lambda * args : None
266+ TestIdRes .setUp (self )
267+
268+ def tearDown (self ):
269+ oidutil .log = self .old_logger
270+
271+ def test_missingNonce (self ):
272+ setup_url = 'http://unittest/setup-here'
273+ query = {
274+ 'openid.mode' : 'id_res' ,
275+ 'openid.return_to' : 'return_to' , # No nonce parameter on return_to
276+ 'openid.identity' : self .server_id ,
277+ 'openid.assoc_handle' : 'not_found' ,
278+ }
279+ ret = self .consumer ._doIdRes (query ,
280+ self .consumer_id ,
281+ self .server_id ,
282+ self .server_url ,
283+ )
284+ self .failUnlessEqual (ret .status , 'failure' )
285+ self .failUnlessEqual (ret .identity_url , self .consumer_id )
286+
287+ def test_badNonce (self ):
288+ setup_url = 'http://unittest/setup-here'
289+ query = {
290+ 'openid.mode' : 'id_res' ,
291+ 'openid.return_to' : 'return_to?nonce=xxx' ,
292+ 'openid.identity' : self .server_id ,
293+ 'openid.assoc_handle' : 'not_found' ,
294+ }
295+ ret = self .consumer ._doIdRes (query ,
296+ self .consumer_id ,
297+ self .server_id ,
298+ self .server_url ,
299+ )
300+ self .failUnlessEqual (ret .status , 'failure' )
301+ self .failUnlessEqual (ret .identity_url , self .consumer_id )
302+
303+ def test_twoNonce (self ):
304+ setup_url = 'http://unittest/setup-here'
305+ query = {
306+ 'openid.mode' : 'id_res' ,
307+ 'openid.return_to' : 'return_to?nonce=nonny&nonce=xxx' ,
308+ 'openid.identity' : self .server_id ,
309+ 'openid.assoc_handle' : 'not_found' ,
310+ }
311+ ret = self .consumer ._doIdRes (query ,
312+ self .consumer_id ,
313+ self .server_id ,
314+ self .server_url ,
315+ )
316+ self .failUnlessEqual (ret .status , 'failure' )
317+ self .failUnlessEqual (ret .identity_url , self .consumer_id )
318+
262319class TestCheckAuthTriggered (TestIdRes , CatchLogs ):
263320 consumer_class = CheckAuthDetectingConsumer
264321
0 commit comments