Skip to content

Commit 3952eff

Browse files
author
Kevin Turner
committed
[project @ association.Association._makePairsSignAll: openid.sig isn't a signed item.]
1 parent 915ce6f commit 3952eff

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

‎openid/association.py‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,11 @@ def _makePairs(self, message):
476476

477477

478478
def _makePairsSignAll(self, message):
479-
pairs = message.toPostArgs().items()
479+
pairs = message.toPostArgs()
480+
if 'openid.sig' in pairs:
481+
# A sig does not sign itself.
482+
del pairs['openid.sig']
483+
pairs = pairs.items()
480484
pairs.sort()
481485
return pairs
482486

‎openid/test/test_association.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ def setUp(self):
8282
'mode': 'id_res',
8383
'identifier': '=example',
8484
'signed': 'identifier,mode',
85+
'sig': 'cephalopod',
8586
})
8687
m.updateArgs(BARE_NS, {'xey': 'value'})
8788
self.assoc = association.Association.fromExpiresIn(

0 commit comments

Comments
 (0)