Downloader.py added to get live data - #11
Merged
pythonlessons merged 6 commits intoApr 8, 2024
Merged
Conversation
Owner
|
Thanks I'll check this in coming days |
pythonlessons
changed the base branch from
feature/vick2592
to
feature/developOld
April 8, 2024 12:06
Owner
|
why you were developing on top of build/lib/finrock instead of doing it directly with finrock? |
Owner
|
I merged it to developOld branch, I'll walk through your changes and I'll check them more closely |
Author
|
Cool, looking forward to it. Regarding the developing on top of build/lib/finrock, I am not sure actually why it separated the path during fork. Could be something my Visual Studio environment did. However, the updater.py script that I wanted to use to initiate the pull of new data I placed in the correct Finrock path. I will try to replicate the fork again and keep a lookout why this build folder is created. Thank you for pointing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downloader.py script is used to constantly fetch new data on a selected time frame when called. The code is currently setup to work with the 4H timeframe that you used. I also did not change any names and kept the csv file name the same to not get any conflicts. Also, I updated the requriements.txt file to add the requests' library, as well as a couple other ones that might be useful going forward.
Please review this code and let me know on the next steps where I can help with this project. For now, I will train the data and test it accordingly.