You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates the badge generation script from pycon2025 to pycon2026: new badge counts, conference code/checkin list ID, parallelised badge creation via Promise.all(), in-memory caching of GraphQL responses, and an output manifest (badges-created.json).
Potential issue — cache poisoning on error: CACHED_ORDER_POSITIONS only stores a result after a successful fetch, but if response.data is missing (GraphQL-level error), the call throws before writing to cache. That's fine. However, if response.data.conferenceRoleForTicketData is null or undefined, that value is written to the cache (CACHED_ORDER_POSITIONS[id] = undefined), and subsequent calls will return early with undefined without retrying. Given this runs as a one-off script where a bad result would be immediately visible, the risk is low but worth noting.
Minor: --no-sandbox disables Chromium's sandbox. Acceptable in a trusted Docker environment for a batch script, but should not be carried into any browser-facing or multi-tenant context.
SPONSOR: 20 + 45 — leaving the expression unevaluated is a reasonable way to document the breakdown, though it's unconventional. No functional issue.
No issues with the Promise.all() + cache interaction: the 4 positions per chunk have distinct IDs, and the front/back loop is sequential, so the cache is populated before the back side runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ToDo