Skip to content

2026 badges updates#4644

Merged
marcoacierno merged 3 commits into
mainfrom
2026-badges-updates
May 17, 2026
Merged

2026 badges updates#4644
marcoacierno merged 3 commits into
mainfrom
2026-badges-updates

Conversation

@marcoacierno
Copy link
Copy Markdown
Member

What

ToDo

@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview May 17, 2026 10:07pm

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 17, 2026

Updates the badge generation script from pycon2025 to pycon2026: new badge counts, conference code/checkin list ID, parallelised badge creation via Promise.all(), in-memory caching of GraphQL responses, and an output manifest (badges-created.json).

Potential issue — cache poisoning on error: CACHED_ORDER_POSITIONS only stores a result after a successful fetch, but if response.data is missing (GraphQL-level error), the call throws before writing to cache. That's fine. However, if response.data.conferenceRoleForTicketData is null or undefined, that value is written to the cache (CACHED_ORDER_POSITIONS[id] = undefined), and subsequent calls will return early with undefined without retrying. Given this runs as a one-off script where a bad result would be immediately visible, the risk is low but worth noting.

Minor: --no-sandbox disables Chromium's sandbox. Acceptable in a trusted Docker environment for a batch script, but should not be carried into any browser-facing or multi-tenant context.

SPONSOR: 20 + 45 — leaving the expression unevaluated is a reasonable way to document the breakdown, though it's unconventional. No functional issue.

No issues with the Promise.all() + cache interaction: the 4 positions per chunk have distinct IDs, and the front/back loop is sequential, so the cache is populated before the back side runs.

@marcoacierno marcoacierno merged commit decc331 into main May 17, 2026
5 of 6 checks passed
@marcoacierno marcoacierno deleted the 2026-badges-updates branch May 17, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant