add ZipPkgWriter.close()

Steve Canny · Steve Canny · commit 44d2f8335ddd · 2013-08-05T15:08:41.000-07:00
diff --git a/opc/phys_pkg.py b/opc/phys_pkg.py
@@ -79,3 +79,10 @@ class ZipPkgWriter(object):
     def __init__(self, pkg_file):
         super(ZipPkgWriter, self).__init__()
         self._zipf = ZipFile(pkg_file, 'w', compression=ZIP_DEFLATED)
+
+    def close(self):
+        """
+        Close the zip archive, flushing any pending physical writes and
+        releasing any resources it's using.
+        """
+        self._zipf.close()
diff --git a/tests/test_phys_pkg.py b/tests/test_phys_pkg.py
@@ -115,3 +115,12 @@ def it_opens_pkg_file_zip_on_construction(self, ZipFile_):
         ZipPkgWriter(pkg_file)
         ZipFile_.assert_called_once_with(pkg_file, 'w',
                                          compression=ZIP_DEFLATED)
+
+    def it_can_be_closed(self, ZipFile_):
+        # mockery ----------------------
+        zipf = ZipFile_.return_value
+        zip_pkg_writer = ZipPkgWriter(None)
+        # exercise ---------------------
+        zip_pkg_writer.close()
+        # verify -----------------------
+        zipf.close.assert_called_once_with()
