Skip to content

Commit 30c69a4

Browse files
author
Steve Canny
committed
add ZipPkgReader.close()
1 parent 94cc123 commit 30c69a4

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

opc/phys_pkg.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ def close(self):
3434
"""
3535
Close the zip archive, releasing any resources it is using.
3636
"""
37+
self._zipf.close()
3738

3839
@property
3940
def content_types_xml(self):

tests/test_phys_pkg.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,12 @@ def it_opens_pkg_file_zip_on_construction(self, ZipFile_):
4545
pkg_file = Mock(name='pkg_file')
4646
ZipPkgReader(pkg_file)
4747
ZipFile_.assert_called_once_with(pkg_file, 'r')
48+
49+
def it_can_be_closed(self, ZipFile_):
50+
# mockery ----------------------
51+
zipf = ZipFile_.return_value
52+
zip_pkg_reader = ZipPkgReader(None)
53+
# exercise ---------------------
54+
zip_pkg_reader.close()
55+
# verify -----------------------
56+
zipf.close.assert_called_once_with()

0 commit comments

Comments
 (0)