parfmt: add ParagraphFormat.space_after setter

Steve Canny · Steve Canny · commit d16452e5ca2b · 2015-02-08T00:01:43.000-08:00
diff --git a/docx/oxml/text/paragraph.py b/docx/oxml/text/paragraph.py
@@ -139,6 +139,12 @@ def spacing_after(self):
             return None
         return spacing.after
 
+    @spacing_after.setter
+    def spacing_after(self, value):
+        if value is None and self.spacing is None:
+            return
+        self.get_or_add_spacing().after = value
+
     @property
     def spacing_before(self):
         """
diff --git a/docx/text/paragraph.py b/docx/text/paragraph.py
@@ -170,6 +170,10 @@ def space_after(self):
             return None
         return pPr.spacing_after
 
+    @space_after.setter
+    def space_after(self, value):
+        self._element.get_or_add_pPr().spacing_after = value
+
     @property
     def space_before(self):
         """
diff --git a/features/txt-parfmt-props.feature b/features/txt-parfmt-props.feature
@@ -39,7 +39,6 @@ Feature: Get or set paragraph formatting properties
       | after  | 42 pt     | 533400 |
 
 
-  @wip
   Scenario Outline: Set paragraph spacing
     Given a paragraph format having <setting> space <side>
      When I assign <new-value> to paragraph_format.space_<side>
diff --git a/tests/text/test_paragraph.py b/tests/text/test_paragraph.py
@@ -310,6 +310,11 @@ def it_knows_its_space_after(self, space_after_get_fixture):
         paragraph_format, expected_value = space_after_get_fixture
         assert paragraph_format.space_after == expected_value
 
+    def it_can_change_its_space_after(self, space_after_set_fixture):
+        paragraph_format, value, expected_xml = space_after_set_fixture
+        paragraph_format.space_after = value
+        assert paragraph_format._element.xml == expected_xml
+
     # fixtures -------------------------------------------------------
 
     @pytest.fixture(params=[
@@ -351,6 +356,24 @@ def space_after_get_fixture(self, request):
         paragraph_format = ParagraphFormat(element(p_cxml))
         return paragraph_format, expected_value
 
+    @pytest.fixture(params=[
+        ('w:p',                 Pt(12), 'w:p/w:pPr/w:spacing{w:after=240}'),
+        ('w:p',                 None,   'w:p/w:pPr'),
+        ('w:p/w:pPr',           Pt(12), 'w:p/w:pPr/w:spacing{w:after=240}'),
+        ('w:p/w:pPr',           None,   'w:p/w:pPr'),
+        ('w:p/w:pPr/w:spacing', Pt(12), 'w:p/w:pPr/w:spacing{w:after=240}'),
+        ('w:p/w:pPr/w:spacing', None,   'w:p/w:pPr/w:spacing'),
+        ('w:p/w:pPr/w:spacing{w:after=240}', Pt(42),
+         'w:p/w:pPr/w:spacing{w:after=840}'),
+        ('w:p/w:pPr/w:spacing{w:after=840}', None,
+         'w:p/w:pPr/w:spacing'),
+    ])
+    def space_after_set_fixture(self, request):
+        p_cxml, value, expected_p_cxml = request.param
+        paragraph_format = ParagraphFormat(element(p_cxml))
+        expected_xml = xml(expected_p_cxml)
+        return paragraph_format, value, expected_xml
+
     @pytest.fixture(params=[
         ('w:p',                               None),
         ('w:p/w:pPr',                         None),
