parfmt: add ParagraphFormat.space_before setter

Steve Canny · Steve Canny · commit bc296cf3ece3 · 2015-02-08T00:01:43.000-08:00
diff --git a/docx/oxml/text/paragraph.py b/docx/oxml/text/paragraph.py
@@ -149,6 +149,12 @@ def spacing_before(self):
             return None
         return spacing.before
 
+    @spacing_before.setter
+    def spacing_before(self, value):
+        if value is None and self.spacing is None:
+            return
+        self.get_or_add_spacing().before = value
+
     @property
     def style(self):
         """
diff --git a/docx/text/paragraph.py b/docx/text/paragraph.py
@@ -184,3 +184,7 @@ def space_before(self):
         if pPr is None:
             return None
         return pPr.spacing_before
+
+    @space_before.setter
+    def space_before(self, value):
+        self._element.get_or_add_pPr().spacing_before = value
diff --git a/tests/text/test_paragraph.py b/tests/text/test_paragraph.py
@@ -301,6 +301,11 @@ def it_knows_its_space_before(self, space_before_get_fixture):
         paragraph_format, expected_value = space_before_get_fixture
         assert paragraph_format.space_before == expected_value
 
+    def it_can_change_its_space_before(self, space_before_set_fixture):
+        paragraph_format, value, expected_xml = space_before_set_fixture
+        paragraph_format.space_before = value
+        assert paragraph_format._element.xml == expected_xml
+
     def it_knows_its_space_after(self, space_after_get_fixture):
         paragraph_format, expected_value = space_after_get_fixture
         assert paragraph_format.space_after == expected_value
@@ -356,3 +361,21 @@ def space_before_get_fixture(self, request):
         p_cxml, expected_value = request.param
         paragraph_format = ParagraphFormat(element(p_cxml))
         return paragraph_format, expected_value
+
+    @pytest.fixture(params=[
+        ('w:p',                 Pt(12), 'w:p/w:pPr/w:spacing{w:before=240}'),
+        ('w:p',                 None,   'w:p/w:pPr'),
+        ('w:p/w:pPr',           Pt(12), 'w:p/w:pPr/w:spacing{w:before=240}'),
+        ('w:p/w:pPr',           None,   'w:p/w:pPr'),
+        ('w:p/w:pPr/w:spacing', Pt(12), 'w:p/w:pPr/w:spacing{w:before=240}'),
+        ('w:p/w:pPr/w:spacing', None,   'w:p/w:pPr/w:spacing'),
+        ('w:p/w:pPr/w:spacing{w:before=240}', Pt(42),
+         'w:p/w:pPr/w:spacing{w:before=840}'),
+        ('w:p/w:pPr/w:spacing{w:before=840}', None,
+         'w:p/w:pPr/w:spacing'),
+    ])
+    def space_before_set_fixture(self, request):
+        p_cxml, value, expected_p_cxml = request.param
+        paragraph_format = ParagraphFormat(element(p_cxml))
+        expected_xml = xml(expected_p_cxml)
+        return paragraph_format, value, expected_xml
