style: add BaseStyle.unhide_when_used setter

Steve Canny · Steve Canny · commit a6b429b436b1 · 2015-02-08T00:01:46.000-08:00
diff --git a/docx/oxml/styles.py b/docx/oxml/styles.py
@@ -154,6 +154,13 @@ def unhideWhenUsed_val(self):
             return False
         return unhideWhenUsed.val
 
+    @unhideWhenUsed_val.setter
+    def unhideWhenUsed_val(self, value):
+        self._remove_unhideWhenUsed()
+        if bool(value) is True:
+            unhideWhenUsed = self._add_unhideWhenUsed()
+            unhideWhenUsed.val = value
+
 
 class CT_Styles(BaseOxmlElement):
     """
diff --git a/docx/styles/style.py b/docx/styles/style.py
@@ -135,6 +135,10 @@ def unhide_when_used(self):
         """
         return self._element.unhideWhenUsed_val
 
+    @unhide_when_used.setter
+    def unhide_when_used(self, value):
+        self._element.unhideWhenUsed_val = value
+
     @staticmethod
     def _translate_special_case_names(name):
         """
diff --git a/features/sty-style-props.feature b/features/sty-style-props.feature
@@ -108,7 +108,6 @@ Feature: Get and set style properties
       | no setting | False |
 
 
-  @wip
   Scenario Outline: Set unhide-when-used value
     Given a style having unhide-when-used set <setting>
      When I assign <new-value> to style.unhide_when_used
diff --git a/tests/styles/test_style.py b/tests/styles/test_style.py
@@ -145,6 +145,11 @@ def it_knows_whether_its_unhide_when_used(self, unhide_get_fixture):
         style, expected_value = unhide_get_fixture
         assert style.unhide_when_used == expected_value
 
+    def it_can_change_its_unhide_when_used_value(self, unhide_set_fixture):
+        style, value, expected_xml = unhide_set_fixture
+        style.unhide_when_used = value
+        assert style._element.xml == expected_xml
+
     def it_can_delete_itself_from_the_document(self, delete_fixture):
         style, styles, expected_xml = delete_fixture
         style.delete()
@@ -282,6 +287,26 @@ def unhide_get_fixture(self, request):
         style = BaseStyle(element(style_cxml))
         return style, expected_value
 
+    @pytest.fixture(params=[
+        ('w:style',                           True,
+         'w:style/w:unhideWhenUsed'),
+        ('w:style/w:unhideWhenUsed',          False,
+         'w:style'),
+        ('w:style/w:unhideWhenUsed{w:val=0}', True,
+         'w:style/w:unhideWhenUsed'),
+        ('w:style/w:unhideWhenUsed{w:val=1}', True,
+         'w:style/w:unhideWhenUsed'),
+        ('w:style/w:unhideWhenUsed{w:val=1}', False,
+         'w:style'),
+        ('w:style',                           False,
+         'w:style'),
+    ])
+    def unhide_set_fixture(self, request):
+        style_cxml, value, expected_cxml = request.param
+        style = BaseStyle(element(style_cxml))
+        expected_xml = xml(expected_cxml)
+        return style, value, expected_xml
+
 
 class Describe_CharacterStyle(object):
 
