text: add Run.italic setter

Steve Canny · Steve Canny · commit 86ae5d2a446a · 2014-01-04T21:37:29.000-08:00
diff --git a/docx/oxml/text.py b/docx/oxml/text.py
@@ -260,6 +260,14 @@ def add_b(self):
         self.insert(0, b)
         return b
 
+    def add_i(self):
+        """
+        Return a newly added <w:i/> child element.
+        """
+        i = OxmlElement('w:i')
+        self.insert(0, i)
+        return i
+
     @property
     def b(self):
         """
@@ -286,6 +294,11 @@ def remove_b(self):
         for b in b_lst:
             self.remove(b)
 
+    def remove_i(self):
+        i_lst = self.findall(qn('w:i'))
+        for i in i_lst:
+            self.remove(i)
+
 
 class CT_Text(OxmlBaseElement):
     """
diff --git a/docx/text.py b/docx/text.py
@@ -132,6 +132,15 @@ def italic(self):
             return None
         return i.val
 
+    @italic.setter
+    def italic(self, value):
+        rPr = self._r.get_or_add_rPr()
+        rPr.remove_i()
+        if value is not None:
+            i = rPr.add_i()
+            if bool(value) is False:
+                i.val = False
+
     @property
     def text(self):
         """
diff --git a/features/run-bold-italic.feature b/features/run-bold-italic.feature
@@ -18,19 +18,16 @@ Feature: Apply bold or italic to run
      When I assign False to its bold property
      Then the run appears without bold regardless of its style hierarchy
 
-  @wip
   Scenario: Apply italic to a run
     Given a run
      When I assign True to its italic property
      Then the run appears in italic typeface
 
-  @wip
   Scenario: Remove italic from a run
     Given a run having italic set on
      When I assign None to its italic property
      Then the run appears with its inherited italic setting
 
-  @wip
   Scenario: Set italic off unconditionally
     Given a run
      When I assign False to its italic property
diff --git a/tests/test_text.py b/tests/test_text.py
@@ -103,6 +103,11 @@ def it_can_change_its_bold_setting(self, bold_set_fixture):
         run.bold = bold_value
         assert run._r.xml == expected_xml
 
+    def it_can_change_its_italic_setting(self, italic_set_fixture):
+        run, italic_value, expected_xml = italic_set_fixture
+        run.italic = italic_value
+        assert run._r.xml == expected_xml
+
     def it_can_add_text(self, add_text_fixture):
         run, text_str, expected_xml, Text_ = add_text_fixture
         _text = run.add_text(text_str)
@@ -195,6 +200,23 @@ def bold_set_fixture(self, request):
         expected_xml = an_r().with_nsdecls().with_child(rPr_bldr).xml()
         return run, bold_value, expected_xml
 
+    @pytest.fixture(params=[True, False, None])
+    def italic_set_fixture(self, request):
+        # run --------------------------
+        r = an_r().with_nsdecls().element
+        run = Run(r)
+        # italic_value -------------------
+        italic_value = request.param
+        # expected_xml -----------------
+        rPr_bldr = an_rPr()
+        if italic_value is not None:
+            i_bldr = an_i()
+            if italic_value is False:
+                i_bldr.with_val(0)
+            rPr_bldr.with_child(i_bldr)
+        expected_xml = an_r().with_nsdecls().with_child(rPr_bldr).xml()
+        return run, italic_value, expected_xml
+
     @pytest.fixture
     def run(self):
         r = an_r().with_nsdecls().element
