parfmt: add ParagraphFormat.right_indent setter

Steve Canny · Steve Canny · commit 4863ac986d54 · 2015-02-08T00:01:44.000-08:00
diff --git a/docx/oxml/text/paragraph.py b/docx/oxml/text/paragraph.py
@@ -182,6 +182,13 @@ def ind_right(self):
             return None
         return ind.right
 
+    @ind_right.setter
+    def ind_right(self, value):
+        if value is None and self.ind is None:
+            return
+        ind = self.get_or_add_ind()
+        ind.right = value
+
     @property
     def jc_val(self):
         """
diff --git a/docx/text/paragraph.py b/docx/text/paragraph.py
@@ -270,6 +270,11 @@ def right_indent(self):
             return None
         return pPr.ind_right
 
+    @right_indent.setter
+    def right_indent(self, value):
+        pPr = self._element.get_or_add_pPr()
+        pPr.ind_right = value
+
     @property
     def space_after(self):
         """
diff --git a/features/txt-parfmt-props.feature b/features/txt-parfmt-props.feature
@@ -110,7 +110,6 @@ Feature: Get or set paragraph formatting properties
       | right      | 17.3 pt  | 219710  |
 
 
-  @wip
   Scenario Outline: Set paragraph indents
     Given a paragraph format having <type> indent of <setting>
      When I assign <new-value> to paragraph_format.<type>_indent
diff --git a/tests/text/test_paragraph.py b/tests/text/test_paragraph.py
@@ -356,6 +356,11 @@ def it_knows_its_right_indent(self, right_indent_get_fixture):
         paragraph_format, expected_value = right_indent_get_fixture
         assert paragraph_format.right_indent == expected_value
 
+    def it_can_change_its_right_indent(self, right_indent_set_fixture):
+        paragraph_format, value, expected_xml = right_indent_set_fixture
+        paragraph_format.right_indent = value
+        assert paragraph_format._element.xml == expected_xml
+
     # fixtures -------------------------------------------------------
 
     @pytest.fixture(params=[
@@ -530,6 +535,19 @@ def right_indent_get_fixture(self, request):
         paragraph_format = ParagraphFormat(element(p_cxml))
         return paragraph_format, expected_value
 
+    @pytest.fixture(params=[
+        ('w:p', Pt(36), 'w:p/w:pPr/w:ind{w:right=720}'),
+        ('w:p', Pt(-3), 'w:p/w:pPr/w:ind{w:right=-60}'),
+        ('w:p', 0,      'w:p/w:pPr/w:ind{w:right=0}'),
+        ('w:p', None,   'w:p/w:pPr'),
+        ('w:p/w:pPr/w:ind{w:right=240}', None, 'w:p/w:pPr/w:ind'),
+    ])
+    def right_indent_set_fixture(self, request):
+        p_cxml, value, expected_p_cxml = request.param
+        paragraph_format = ParagraphFormat(element(p_cxml))
+        expected_xml = xml(expected_p_cxml)
+        return paragraph_format, value, expected_xml
+
     @pytest.fixture(params=[
         ('w:p',                              None),
         ('w:p/w:pPr',                        None),
