tbl: add Table.column_cells()

Steve Canny · Steve Canny · commit 2fda57040311 · 2014-11-28T21:45:42.000-05:00
diff --git a/docx/table.py b/docx/table.py
@@ -65,7 +65,9 @@ def column_cells(self, column_idx):
         """
         Sequence of cells in the column at *column_idx* in this table.
         """
-        raise NotImplementedError
+        cells = self._cells
+        idxs = range(column_idx, len(cells), self._column_count)
+        return [cells[idx] for idx in idxs]
 
     @lazyproperty
     def columns(self):
diff --git a/features/tbl-cell-access.feature b/features/tbl-cell-access.feature
@@ -15,7 +15,6 @@ Feature: Access table cells
       | a combined span    | 1 2 3 4 4 6 4 4 9 |
 
 
-  @wip
   Scenario Outline: Access cell sequence of a column
      Given a 3x3 table having <span-state>
       Then the column cells text is <expected-text>
@@ -28,7 +27,6 @@ Feature: Access table cells
       | a combined span    | 1 4 4 2 4 4 3 6 9 |
 
 
-  @wip
   Scenario Outline: Access cell by row and column index
      Given a 3x3 table having <span-state>
       Then table.cell(<row>, <col>).text is <expected-text>
diff --git a/tests/test_table.py b/tests/test_table.py
@@ -41,6 +41,11 @@ def it_provides_access_to_a_cell_by_row_and_col_indices(self, table):
                 tc = tr.tc_lst[col_idx]
                 assert tc is cell._tc
 
+    def it_provides_access_to_the_cells_in_a_column(self, col_cells_fixture):
+        table, column_idx, expected_cells = col_cells_fixture
+        column_cells = table.column_cells(column_idx)
+        assert column_cells == expected_cells
+
     def it_provides_access_to_the_cells_in_a_row(self, row_cells_fixture):
         table, row_idx, expected_cells = row_cells_fixture
         row_cells = table.row_cells(row_idx)
@@ -155,6 +160,15 @@ def cells_fixture(self, request):
         table = Table(parse_xml(tbl_xml), None)
         return table, cell_count, unique_count, matches
 
+    @pytest.fixture
+    def col_cells_fixture(self, _cells_, _column_count_):
+        table = Table(None, None)
+        _cells_.return_value = [0, 1, 2, 3, 4, 5, 6, 7, 8]
+        _column_count_.return_value = 3
+        column_idx = 1
+        expected_cells = [1, 4, 7]
+        return table, column_idx, expected_cells
+
     @pytest.fixture
     def column_count_fixture(self):
         tbl_cxml = 'w:tbl/w:tblGrid/(w:gridCol,w:gridCol,w:gridCol)'
