text: add Run.italic getter

Steve Canny · Steve Canny · commit 2f2d0b41b041 · 2014-01-04T21:21:15.000-08:00
diff --git a/docx/oxml/__init__.py b/docx/oxml/__init__.py
@@ -41,6 +41,7 @@
 from docx.oxml.text import CT_Br, CT_P, CT_PPr, CT_R, CT_RPr, CT_Text
 register_custom_element_class('w:b', CT_OnOff)
 register_custom_element_class('w:br', CT_Br)
+register_custom_element_class('w:i', CT_OnOff)
 register_custom_element_class('w:p', CT_P)
 register_custom_element_class('w:pPr', CT_PPr)
 register_custom_element_class('w:pStyle', CT_String)
diff --git a/docx/oxml/text.py b/docx/oxml/text.py
@@ -267,6 +267,13 @@ def b(self):
         """
         return self.find(qn('w:b'))
 
+    @property
+    def i(self):
+        """
+        First ``<w:i>`` child element or None if none are present.
+        """
+        return self.find(qn('w:i'))
+
     @classmethod
     def new(cls):
         """
diff --git a/docx/text.py b/docx/text.py
@@ -124,6 +124,13 @@ def italic(self):
         unconditionally. When |None|, the run will inherit its italic setting
         from its style hierarchy.
         """
+        rPr = self._r.rPr
+        if rPr is None:
+            return None
+        i = rPr.i
+        if i is None:
+            return None
+        return i.val
 
     @property
     def text(self):
diff --git a/tests/oxml/unitdata/text.py b/tests/oxml/unitdata/text.py
@@ -78,6 +78,10 @@ def a_t():
     return CT_TextBuilder()
 
 
+def an_i():
+    return CT_OnOffBuilder('w:i')
+
+
 def an_r():
     return CT_RBuilder()
 
diff --git a/tests/test_text.py b/tests/test_text.py
@@ -14,7 +14,7 @@
 
 from mock import call, create_autospec, Mock
 
-from .oxml.unitdata.text import a_b, a_br, a_t, a_p, an_r, an_rPr
+from .oxml.unitdata.text import a_b, a_br, a_t, a_p, an_i, an_r, an_rPr
 from .unitutil import class_mock
 
 
@@ -94,6 +94,10 @@ def it_knows_if_its_bold(self, bold_get_fixture):
         run, is_bold = bold_get_fixture
         assert run.bold == is_bold
 
+    def it_knows_if_its_italic(self, italic_get_fixture):
+        run, is_italic = italic_get_fixture
+        assert run.italic == is_italic
+
     def it_can_change_its_bold_setting(self, bold_set_fixture):
         run, bold_value, expected_xml = bold_set_fixture
         run.bold = bold_value
@@ -160,6 +164,20 @@ def bold_get_fixture(self, request):
         run = Run(r)
         return run, is_bold
 
+    @pytest.fixture(params=[True, False, None])
+    def italic_get_fixture(self, request):
+        is_italic = request.param
+        r_bldr = an_r().with_nsdecls()
+        if is_italic is not None:
+            i_bldr = an_i()
+            if is_italic is False:
+                i_bldr.with_val('off')
+            rPr_bldr = an_rPr().with_child(i_bldr)
+            r_bldr.with_child(rPr_bldr)
+        r = r_bldr.element
+        run = Run(r)
+        return run, is_italic
+
     @pytest.fixture(params=[True, False, None])
     def bold_set_fixture(self, request):
         # run --------------------------
