Fix Dashboard breadcrumb view URL for user profile
#718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanchowdhury
requested changes
Aug 4, 2020
| {{ block.super }} | ||
| {% breadcrumb "Dashboard" "user-proposals-list" %} | ||
| {% breadcrumb "Dashboard" "/profiles" %} | ||
| {% breadcrumb "Profile" "user-profile"%} |
Member
There was a problem hiding this comment.
Given the second param is dummy, and of no use can you add a comment regarding that?
Member
Author
There was a problem hiding this comment.
sure, will work on that.
| {% block breadcrumbs %} | ||
| {{ block.super }} | ||
| {% breadcrumb "Dashboard" "user-proposals-list" %} | ||
| {% breadcrumb "Dashboard" "/profiles" %} |
Member
There was a problem hiding this comment.
Same for here, add the comment for second argument.
sayanchowdhury
approved these changes
Aug 4, 2020
Member
sayanchowdhury
left a comment
sayanchowdhury
left a comment
There was a problem hiding this comment.
LGTM. Better if you squash the commits.
- Update dashboard.html & userprofile.html for user profile for breadcrumb Fixes pythonindia#709 Signed-off-by: Abhishek Mishra <geekabhi@outlook.com> Update breadcrumb viewname & add comments for the same Signed-off-by: Abhishek Mishra <geekabhi@outlook.com> Fix linting in template Signed-off-by: Abhishek Mishra <geekabhi@outlook.com>
abhishekmishragithub
force-pushed
the
fix-breadcrumb
branch
from
32fd0eb to
9365799
Compare
Member
Author
Done. |
palnabarun
reviewed
Aug 5, 2020
Member
palnabarun
left a comment
palnabarun
left a comment
There was a problem hiding this comment.
LGTM! Thanks @abhishekmishragithub for working on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update view URL for
Dashboardbreadcrumb name under user profileThis Fixes #709