Added First Time Speaker field to the create proposal page #710

abhishekmishragithub · 2020-07-07T06:08:27Z

Fix for #707

Here are the screenshots :

anistark · 2020-07-07T07:18:17Z

@abhishekmishragithub Can you check why travis failed?

sayanchowdhury

Overall LGTM, with 1 nitpick

sayanchowdhury · 2020-07-07T07:51:25Z

junction/proposals/forms.py

+    is_first_time_speaker = forms.BooleanField(
+        label="First Time Speaker",
+        required=False,
+        help_text="Please tick, if you are a first time speaker"


nitpick: does it sound good to have check instead of tick?

+1
"check" would sound better.

I had added check initially, but thought it won't sound good. Let me update that.

"mark" might also sound good.

Added, please review 8154280

abhishekmishragithub · 2020-07-07T08:26:55Z

@abhishekmishragithub Can you check why travis failed?

Not, sure. It seems some nox issue. @palnabarun will you be able to help?

ananyo2012 · 2020-07-08T15:33:55Z

@abhishekmishragithub Linter is complaining. Please run nox -s lint. It will auto fix any trivial issue.

palnabarun · 2020-07-08T18:50:49Z

@abhishekmishragithub -- Thank you for taking this up.

One question I had was, should we expose the first time speaker information to the public? Usually, I saw in conferences that this information is just for reviewers. This information may also change the perception of attendees towards the talk and may influence their decision of attending the talk.

What I feel is once a talk is selected, every talk is on the same platform and carries equal weight to the conference.

With that said, I feel the information should be removed from the proposal view.

What do you think? @sayanchowdhury @anistark @ananyo2012

anistark · 2020-07-08T18:53:35Z

@abhishekmishragithub -- Thank you for taking this up.

One question I had was, should we expose the first time speaker information to the public? Usually, I saw in conferences that this information is just for reviewers. This information may also change the perception of attendees towards the talk and may influence their decision of attending the talk.

What I feel is once a talk is selected, every talk is on the same platform and carries equal weight to the conference.

With that said, I feel the information should be removed from the proposal view.

What do you think? @sayanchowdhury @anistark @ananyo2012

Good point. I think it should only be available to reviewers.

ananyo2012 · 2020-07-16T18:14:54Z

Yes should be visible only to reviewers.

sayanchowdhury · 2020-07-20T04:49:09Z

Agreed this should only be visible to reviewers.

sayanchowdhury · 2020-07-20T04:51:36Z

junction/templates/proposals/detail/base.html

          </div>
          {% endif %}

+          {% if proposal.is_first_time_speaker %}


Maybe just add the check here, if the logged-in person is a reviewer.

sayanchowdhury · 2020-07-20T04:52:12Z

junction/templates/proposals/detail/base.html

+          {% if proposal.is_first_time_speaker %}
+          <div class="proposal-writeup--section">
+            <h4 class='heading'><b>First Time Speaker:</b></h4>
+            <p> Yes</p>


Do we use any library like font-awesome? Instead of yes we can show a ✔️

anistark · 2020-07-30T11:27:59Z

@abhishekmishragithub Can we make the changes requested above and merge this?

- Add `is_first_time_speaker` field in proposal form & model - Update proposals/views.py - Add first time speaker checkbox field in proposals/detail/base.html - Add migration for Proposal model

…/forms.py

abhishekmishragithub · 2020-07-31T21:37:02Z

Added suggested changes.
cc: @palnabarun @sayanchowdhury @anistark

junction/templates/proposals/detail/base.html

anistark

I think the reviewer only view of First Time Speaker is pending. Please cross-check once more.

- Show first time speaker label on proposal page only to author & reviewer - Reorder first time speaker checkbox in proposal form

abhishekmishragithub · 2020-08-01T22:30:06Z

I think the reviewer only view of First Time Speaker is pending. Please cross-check once more.

Fixed in a new commit. Please check.
Only author, reviewer & super user will be able to see the "First time speaker" label

palnabarun

Other than the changes requested, LGTM.

junction/templates/proposals/detail/base.html

palnabarun

LGTM!

Thanks @abhishekmishragithub !!!

abhishekmishragithub changed the title ~~Added First Time Speaker to the create proposal page~~ Added First Time Speaker field to the create proposal page Jul 7, 2020

anistark requested a review from palnabarun July 7, 2020 07:18

anistark assigned palnabarun Jul 7, 2020

anistark added the type/feature-request label Jul 7, 2020

sayanchowdhury approved these changes Jul 7, 2020

View reviewed changes

palnabarun assigned abhishekmishragithub and unassigned palnabarun Jul 8, 2020

sayanchowdhury reviewed Jul 20, 2020

View reviewed changes

abhishekmishragithub force-pushed the first-time-speaker branch from 8154280 to aeefde9 Compare July 31, 2020 20:34

abhishekmishragithub added 4 commits August 1, 2020 02:30

Add First Time Speaker field in create proposal page

a263740

- Add `is_first_time_speaker` field in proposal form & model - Update proposals/views.py - Add first time speaker checkbox field in proposals/detail/base.html - Add migration for Proposal model

Update help_text parameter of is_first_time_speaker field in proposal…

ed0b4a0

…/forms.py

Fix linting error

82d6387

Update proposal base.html for first time speaker

adf8ee7

abhishekmishragithub force-pushed the first-time-speaker branch from 2a25ef9 to adf8ee7 Compare July 31, 2020 21:08

Update proposal form's help text for is_first_time_speaker field

4030879

anistark reviewed Aug 1, 2020

View reviewed changes

junction/templates/proposals/detail/base.html Outdated Show resolved Hide resolved

anistark requested changes Aug 1, 2020

View reviewed changes

Update base.html & forms.py of proposal page

d8ffda2

- Show first time speaker label on proposal page only to author & reviewer - Reorder first time speaker checkbox in proposal form

palnabarun requested changes Aug 2, 2020

View reviewed changes

junction/templates/proposals/detail/base.html Outdated Show resolved Hide resolved

junction/templates/proposals/detail/base.html Outdated Show resolved Hide resolved

Remove unwanted characters & extra lines

5515f8a

abhishekmishragithub requested a review from palnabarun August 3, 2020 05:51

palnabarun approved these changes Aug 3, 2020

View reviewed changes

palnabarun merged commit 4c522c5 into pythonindia:master Aug 3, 2020

abhishekmishragithub mentioned this pull request Aug 3, 2020

Add first time speaker checkbox field in cfp form #707

Closed

Added First Time Speaker field to the create proposal page #710

Added First Time Speaker field to the create proposal page #710

Uh oh!

Conversation

abhishekmishragithub commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anistark commented Jul 7, 2020

Uh oh!

sayanchowdhury left a comment

Choose a reason for hiding this comment

Uh oh!

sayanchowdhury Jul 7, 2020

Choose a reason for hiding this comment

Uh oh!

anistark Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhishekmishragithub Jul 7, 2020

Choose a reason for hiding this comment

Uh oh!

anistark Jul 7, 2020

Choose a reason for hiding this comment

Uh oh!

abhishekmishragithub Jul 7, 2020

Choose a reason for hiding this comment

Uh oh!

abhishekmishragithub commented Jul 7, 2020

Uh oh!

ananyo2012 commented Jul 8, 2020

Uh oh!

palnabarun commented Jul 8, 2020

Uh oh!

anistark commented Jul 8, 2020

Uh oh!

ananyo2012 commented Jul 16, 2020

Uh oh!

sayanchowdhury commented Jul 20, 2020

Uh oh!

sayanchowdhury Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

sayanchowdhury Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

anistark commented Jul 30, 2020

Uh oh!

abhishekmishragithub commented Jul 31, 2020

Uh oh!

Uh oh!

anistark left a comment

Choose a reason for hiding this comment

Uh oh!

abhishekmishragithub commented Aug 1, 2020

Uh oh!

palnabarun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

palnabarun left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

abhishekmishragithub commented Jul 7, 2020 •

edited

Loading

anistark Jul 7, 2020 •

edited

Loading