Add the video URL to the proposal page #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Note: nit: The |
palnabarun
reviewed
May 2, 2020
sayanchowdhury
force-pushed
the
update-video-url
branch
6 times, most recently
from
3549615 to
8ba3d01
Compare
This commit adds the feature to update the proposal with the video URL. The video URL will be containing 1-2 min video about the talk from the speaker. This would help to promote the talk as well as judging better on how the speaker is. Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
sayanchowdhury
force-pushed
the
update-video-url
branch
from
8ba3d01 to
2f954ab
Compare
palnabarun
reviewed
May 2, 2020
Member
palnabarun
left a comment
palnabarun
left a comment
There was a problem hiding this comment.
Did you test the changes by running Junction locally?
Comment on lines
+8
to
+33
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ("proposals", "0026_auto_20200323_2010"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name="historicalproposal", | ||
| name="video_url", | ||
| field=models.URLField( | ||
| blank=True, | ||
| default="", | ||
| help_text="A short 1-2 mins video link about your talk", | ||
| ), | ||
| ), | ||
| migrations.AddField( | ||
| model_name="proposal", | ||
| name="video_url", | ||
| field=models.URLField( | ||
| blank=True, | ||
| default="", | ||
| help_text="A short 1-2 mins video link about your talk", | ||
| ), | ||
| ), | ||
| ] |
Member
There was a problem hiding this comment.
Just trying to understand why there are two migrations?
Member
Author
There was a problem hiding this comment.
Yes, these changes are tested. The historical data is added from django-simple-history which I guess provides kind of an audit log.
palnabarun
approved these changes
May 2, 2020
palnabarun
added a commit
to palnabarun/junction
that referenced
this pull request
Jun 17, 2020
Related to pythonindia#668 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun
added a commit
that referenced
this pull request
Jun 17, 2020
Related to #668 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature to update the proposal with the video URL. The
video URL will be containing 1-2 min video about the talk from the speaker.
This would help to promote the talk as well as judging better on how the speaker
is.