Modified according to @tacaswell comments

montefra · montefra · commit 41bf6b5c6e78 · 2015-03-16T10:38:29.000+01:00
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -971,8 +971,8 @@ def set_clip_path(self, path):
         """
         if path is not None and not isinstance(path,
                 transforms.TransformedPath):
-            msg = "Path should be a matplotlib.transforms.TransformedPath \
-            instance."
+            msg = ("Path should be a matplotlib.transforms.TransformedPath"
+                   "instance.")
             raise ValueError(msg)
         self._clippath = path
 
diff --git a/lib/matplotlib/blocking_input.py b/lib/matplotlib/blocking_input.py
@@ -149,7 +149,7 @@ def post_event(self):
         """
         This will be called to process events
         """
-        if len(self.events) <= 0:
+        if len(self.events) == 0:
             warnings.warn("No events yet")
         elif self.events[-1].name == 'key_press_event':
             self.key_event()
@@ -362,7 +362,7 @@ def post_event(self):
         """
         Determines if it is a key event
         """
-        if len(self.events) <= 0:
+        if len(self.events) == 0:
             warnings.warn("No events yet")
         else:
             self.keyormouse = self.events[-1].name == 'key_press_event'
diff --git a/lib/matplotlib/contour.py b/lib/matplotlib/contour.py
@@ -858,11 +858,11 @@ def __init__(self, ax, *args, **kwargs):
             self.logscale = False
 
         if self.origin not in [None, 'lower', 'upper', 'image']:
-            raise ValueError("If given, *origin* must be one of ['lower', \
-                    'upper', 'image']")
+            raise ValueError("If given, *origin* must be one of ['lower',"
+                             " 'upper', 'image']")
         if self.extent is not None and len(self.extent) != 4:
-            raise ValueError("If give, *extent* must be '[ *None* | \
-            (x0,x1,y0,y1) ]'")
+            raise ValueError("If given, *extent* must be '[ *None* |"
+                             " (x0,x1,y0,y1) ]'")
         if self.colors is not None and cmap is not None:
             raise ValueError('Either colors or cmap must be None')
         if self.origin == 'image':
diff --git a/lib/matplotlib/finance.py b/lib/matplotlib/finance.py
@@ -860,18 +860,16 @@ def _missing(sequence, miss=-1):
         """
         return np.where(np.array(sequence) == miss)[0]
 
-    same_length = (len(opens) == len(highs)) and (len(opens) == len(lows)) and\
-                  (len(opens) == len(closes))
+    same_length = len(opens) == len(highs) == len(lows) == len(closes)
     _missopens = _missing(opens)
-    same_missing = (_missopens == _missing(highs)).all() and (_missopens ==
-        _missing(lows)).all() and (_missopens == _missing(closes)).all()
+    same_missing = ((_missopens == _missing(highs)).all() and
+                    (_missopens == _missing(lows)).all() and 
+                    (_missopens == _missing(closes)).all())
 
     if not (same_length and same_missing):
-        msg = """
-        *opens*, *highs*, *lows* and *closes* must have the same length.
-        NOTE: this code assumes if any value open, high, low, close is
-        missing (*-1*) they all must be missing
-        """
+        msg = ("*opens*, *highs*, *lows* and *closes* must have the same"
+               " length. NOTE: this code assumes if any value open, high,"
+               "low, close is missing (*-1*) they all must be missing.")
         raise ValueError(msg)
 
 
diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py
@@ -3094,8 +3094,8 @@ def ensure_quadratic_bezier(path):
             its control points if true.
             """
             segments = list(path.iter_segments())
-            if (len(segments) != 2) or (segments[0][1] != Path.MOVETO) or\
-               (segments[1][1] != Path.CURVE3):
+            if ((len(segments) != 2) or (segments[0][1] != Path.MOVETO) or
+                    (segments[1][1] != Path.CURVE3)):
                 msg = "'path' it's not a valid quadratic bezier curve"
                 raise ValueError(msg)
 
diff --git a/lib/matplotlib/transforms.py b/lib/matplotlib/transforms.py
@@ -2465,6 +2465,7 @@ def __init__(self, boxin, boxout, **kwargs):
         """
         if not boxin.is_bbox or not boxout.is_bbox:
             msg = "'boxin' and 'boxout' must be bbox"
+            raise ValueError(msg)
 
         Affine2DBase.__init__(self, **kwargs)
         self._boxin = boxin
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -1307,7 +1307,7 @@ def __init__(self, ax, onselect, direction, minspan=None, useblit=False,
             rectprops = dict(facecolor='red', alpha=0.5)
 
         if direction not in ['horizontal', 'vertical']:
-            raise ValueError('Must choose horizontal or vertical for direction')
+            raise ValueError("direction must be in ['horizontal', 'vertical']")
         self.direction = direction
 
         self.rect = None
