fix per-hook fail_fast to not fail on previous failures

asottile · asottile · commit fc622159a6c5 · 2024-03-24T13:17:00.000-04:00
diff --git a/pre_commit/commands/run.py b/pre_commit/commands/run.py
@@ -298,7 +298,7 @@ def _run_hooks(
             verbose=args.verbose, use_color=args.color,
         )
         retval |= current_retval
-        if retval and (config['fail_fast'] or hook.fail_fast):
+        if current_retval and (config['fail_fast'] or hook.fail_fast):
             break
     if retval and args.show_diff_on_failure and prior_diff:
         if args.all_files:
diff --git a/tests/commands/run_test.py b/tests/commands/run_test.py
@@ -1088,6 +1088,22 @@ def test_fail_fast_per_hook(cap_out, store, repo_with_failing_hook):
     assert printed.count(b'Failing hook') == 1
 
 
+def test_fail_fast_not_prev_failures(cap_out, store, repo_with_failing_hook):
+    with modify_config() as config:
+        config['repos'].append({
+            'repo': 'meta',
+            'hooks': [
+                {'id': 'identity', 'fail_fast': True},
+                {'id': 'identity', 'name': 'run me!'},
+            ],
+        })
+    stage_a_file()
+
+    ret, printed = _do_run(cap_out, store, repo_with_failing_hook, run_opts())
+    # should still run the last hook since the `fail_fast` one didn't fail
+    assert printed.count(b'run me!') == 1
+
+
 def test_classifier_removes_dne():
     classifier = Classifier(('this_file_does_not_exist',))
     assert classifier.filenames == []

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ def _run_hooks(`
`298`	`298`	`verbose=args.verbose, use_color=args.color,`
`299`	`299`	`)`
`300`	`300`	`retval \|= current_retval`
`301`		`- if retval and (config['fail_fast'] or hook.fail_fast):`
	`301`	`+ if current_retval and (config['fail_fast'] or hook.fail_fast):`
`302`	`302`	`break`
`303`	`303`	`if retval and args.show_diff_on_failure and prior_diff:`
`304`	`304`	`if args.all_files:`