Merge pull request pre-commit#3584 from pre-commit/exitstack

asottile · web-flow · commit e436690f140c · 2025-11-21T15:19:53.000-05:00
use ExitStack instead of start + stop
diff --git a/tests/main_test.py b/tests/main_test.py
@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import argparse
+import contextlib
 import os.path
 from unittest import mock
 
@@ -97,11 +98,9 @@ def test_adjust_args_try_repo_repo_relative(in_git_dir):
 
 @pytest.fixture
 def mock_commands():
-    mcks = {fn: mock.patch.object(main, fn).start() for fn in FNS}
-    ret = auto_namedtuple(**mcks)
-    yield ret
-    for mck in ret:
-        mck.stop()
+    with contextlib.ExitStack() as ctx:
+        mcks = {f: ctx.enter_context(mock.patch.object(main, f)) for f in FNS}
+        yield auto_namedtuple(**mcks)
 
 
 @pytest.fixture
