Fix python.healthy() check with stdlib module clashes

asottile · asottile · commit bfcee8ec9fb5 · 2019-10-22T13:23:57.000-07:00
diff --git a/pre_commit/languages/python.py b/pre_commit/languages/python.py
@@ -147,6 +147,7 @@ def healthy(prefix, language_version):
             retcode, _, _ = cmd_output_b(
                 'python', '-c',
                 'import ctypes, datetime, io, os, ssl, weakref',
+                cwd='/',
                 retcode=None,
             )
         return retcode == 0
diff --git a/tests/languages/python_test.py b/tests/languages/python_test.py
@@ -7,7 +7,9 @@
 import mock
 import pytest
 
+import pre_commit.constants as C
 from pre_commit.languages import python
+from pre_commit.prefix import Prefix
 
 
 def test_norm_version_expanduser():
@@ -48,3 +50,11 @@ def test_find_by_sys_executable(exe, realpath, expected):
         with mock.patch.object(os.path, 'realpath', return_value=realpath):
             with mock.patch.object(python, 'find_executable', lambda x: x):
                 assert python._find_by_sys_executable() == expected
+
+
+def test_healthy_types_py_in_cwd(tmpdir):
+    with tmpdir.as_cwd():
+        # even if a `types.py` file exists, should still be healthy
+        tmpdir.join('types.py').ensure()
+        # this env doesn't actually exist (for test speed purposes)
+        assert python.healthy(Prefix(str(tmpdir)), C.DEFAULT) is True

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,7 @@ def healthy(prefix, language_version):`
`147`	`147`	`retcode, _, _ = cmd_output_b(`
`148`	`148`	`'python', '-c',`
`149`	`149`	`'import ctypes, datetime, io, os, ssl, weakref',`
	`150`	`+ cwd='/',`
`150`	`151`	`retcode=None,`
`151`	`152`	`)`
`152`	`153`	`return retcode == 0`