Merge pull request pre-commit#2315 from pre-commit/error-messages

asottile · web-flow · commit a5225070208d · 2022-03-30T12:54:37.000-04:00
include the configured value in the language_version / additional_dependencies error
diff --git a/pre_commit/languages/helpers.py b/pre_commit/languages/helpers.py
@@ -67,7 +67,8 @@ def environment_dir(d: str | None, language_version: str) -> str | None:
 def assert_version_default(binary: str, version: str) -> None:
     if version != C.DEFAULT:
         raise AssertionError(
-            f'For now, pre-commit requires system-installed {binary}',
+            f'for now, pre-commit requires system-installed {binary} -- '
+            f'you selected `language_version: {version}`',
         )
 
 
@@ -77,8 +78,9 @@ def assert_no_additional_deps(
 ) -> None:
     if additional_deps:
         raise AssertionError(
-            f'For now, pre-commit does not support '
-            f'additional_dependencies for {lang}',
+            f'for now, pre-commit does not support '
+            f'additional_dependencies for {lang} -- '
+            f'you selected `additional_dependencies: {additional_deps}`',
         )
 
 
diff --git a/tests/languages/helpers_test.py b/tests/languages/helpers_test.py
@@ -88,7 +88,9 @@ def test_assert_no_additional_deps():
         helpers.assert_no_additional_deps('lang', ['hmmm'])
     msg, = excinfo.value.args
     assert msg == (
-        'For now, pre-commit does not support additional_dependencies for lang'
+        'for now, pre-commit does not support additional_dependencies for '
+        'lang -- '
+        "you selected `additional_dependencies: ['hmmm']`"
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,9 @@ def test_assert_no_additional_deps():`
`88`	`88`	`helpers.assert_no_additional_deps('lang', ['hmmm'])`
`89`	`89`	`msg, = excinfo.value.args`
`90`	`90`	`assert msg == (`
`91`		`- 'For now, pre-commit does not support additional_dependencies for lang'`
	`91`	`+ 'for now, pre-commit does not support additional_dependencies for '`
	`92`	`+ 'lang -- '`
	`93`	+ "you selected `additional_dependencies: ['hmmm']`"
`92`	`94`	`)`
`93`	`95`
`94`	`96`